Repository navigation
fix: 修正 appId/desktopName 反向域名为 top.imsyy - #36
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5 <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
本 PR 旨在将项目的应用标识从不受维护者控制的 com.imsyy.* 迁移到受控的 top.imsyy.*，并同步更新 Windows（AUMID/安装器标识）与 Linux（desktopName/MPRIS desktop_entry）相关字段，确保各平台系统集成一致。
Changes:
- 更新
electron-builder的appId与 NSISguid为top.imsyy.splayer-next - 主进程同步更新 Windows
setAppUserModelId为top.imsyy.splayer-next - Linux 侧同步更新
package.json.desktopName与 MPRISdesktop_entry为top.imsyy.splayer_next
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | 将 desktopName 切换为 top.imsyy.splayer_next 以匹配 Linux .desktop 命名约束与派生逻辑 |
| native/media-ctrl/src/sys_media/linux.rs | 更新 MPRIS desktop_entry，确保媒体控件能正确关联到对应 .desktop 条目 |
| electron/main/core/index.ts | 更新 Windows AUMID（setAppUserModelId）以与新的 appId 对齐 |
| electron-builder.config.ts | 更新构建产物的 appId 与 NSIS guid，清理旧反向域名残留并统一标识 |
roarrabbit
pushed a commit
to roarrabbit/SPlayer-Next
that referenced
this pull request
Aug 27, 2026
…p-id fix: 修正 appId/desktopName 反向域名为 top.imsyy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
修正 #33：项目当前使用
com.imsyy.splayer-next作为 appId / desktopName，但imsyy.com域名不受维护者控制。趁正式发布前改为受控的top.imsyy反向域名。改动
electron-builder.config.tsappIdtop.imsyy.splayer-next（保留连字符）electron-builder.config.tsnsis.guidtop.imsyy.splayer-next（原镜像 appId，一并清掉 com.imsyy 残留）electron/main/core/index.tssetAppUserModelIdtop.imsyy.splayer-next（Windows AUMID 必须等于 appId）package.jsondesktopNametop.imsyy.splayer_next（下划线）native/media-ctrl/src/sys_media/linux.rsdesktop_entrytop.imsyy.splayer_next（必须等于 .desktop 文件名）为什么 desktopName 用下划线、appId 用连字符
按 #33 的建议：部分反向域名用法（D-Bus 对象路径 / 接口名、Flatpak App ID）禁止连字符，故
desktopName用_；appId仍保留-。经 electron-builder（app-builder-lib 26.15.3）源码确认其一致性：
syncDesktopName: true时，.desktop文件名与 Electron 的 Linux app_id /StartupWMClass均派生自package.json.desktopName。因此 MPRIS 的desktop_entry必须同步改为top.imsyy.splayer_next，否则 Linux 媒体控件无法关联应用图标。有意保留的
splayer-next（连字符）这些不是反向域名标识，不受相关限制，未改动：更新器缓存目录名、流媒体 deviceId、MPRIS 总线名后缀（D-Bus 总线名允许连字符）。
🤖 Generated with Claude Code