Repository navigation
fix: 修复播放器展开状态被意外持久化,顺便小改相关的地方 - #119
Merged
Merged
Conversation
MoYingJi
force-pushed
the
pr/fix/player-expanded
branch
from
July 28, 2026 17:11
b68480f to
b131e54
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
修复全屏播放器展开状态被意外持久化的问题,并统一状态命名。
Changes:
- 恢复
pick持久化白名单并加入列表排序字段。 - 将
isExpanded重命名为isPlayerExpanded。 - 同步更新全屏播放器相关引用。
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/stores/status.ts |
修正持久化策略并重命名状态 |
src/layouts/MainLayout.vue |
更新布局状态引用 |
src/core/hotkey/registry.ts |
更新播放器快捷操作 |
src/composables/useImmersiveMode.ts |
更新沉浸模式参数命名 |
src/components/player/TrackInfo.vue |
更新播放器展开操作 |
src/components/player/FullPlayer/PlayerData.vue |
更新页面跳转时的收起操作 |
src/components/player/FullPlayer/PlayerCover.vue |
更新高清封面加载条件 |
src/components/player/FullPlayer/PlayerBackground.vue |
更新背景生命周期条件 |
src/components/player/FullPlayer/index.vue |
更新全屏播放器状态引用 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改动类型
是否包含破坏性变更
改动说明
statusStore持久化策略改为黑名单(omit)后,播放器展开状态(isExpanded)等纯 UI 状态被意外写入 localStorage,导致刷新页面后播放器为展开状态,且此时的播放器右侧的歌词消失(我是 AMLL),与预期行为不符。第一个 commit 修复了此问题,并改回pickisExpanded命名过于泛化,原注释菜单折叠状态与实际用途(全屏播放器展开状态)完全不符,影响代码可读性和维护性。第二个 commit 将isExpanded重命名为isPlayerExpanded并修改注释(我在想是不是叫fullPlayerOpen好一点,但既然原来叫)isExpanded肯定有它的深意测试情况
在 Arch Linux 上测试通过
自查清单
pnpm format,并确认pnpm typecheck、pnpm lint通过pnpm build:native验证;未手写native/*/index.d.tsdev分支提交