Skip to content

Commit d96344e

Browse files
committed
[component]: Fix review comments.
Signed-off-by: Nazarii Hnydyn <[email protected]>
1 parent b066ec7 commit d96344e

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

sonic_platform_base/component_base.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ def get_firmware_version(self):
3434
"""
3535
Retrieves the firmware version of the component
3636
37+
Note: the firmware version will be read from HW
38+
3739
Returns:
3840
A string containing the firmware version of the component
3941
"""
@@ -43,6 +45,8 @@ def get_available_firmware_version(self, image_path):
4345
"""
4446
Retrieves the available firmware version of the component
4547
48+
Note: the firmware version will be read from image
49+
4650
Args:
4751
image_path: A string, path to firmware image
4852
@@ -67,11 +71,11 @@ def get_firmware_update_notification(self, image_path):
6771

6872
def install_firmware(self, image_path):
6973
"""
70-
Installs firmware to the component.
74+
Installs firmware to the component
7175
7276
This API performs firmware installation only: this may/may not be the same as firmware update.
7377
In case platform component requires some extra steps (apart from calling Low Level Utility)
74-
to load the installed firmware (e.g, reboot, power cycle, etc.) - this must be done manually by user.
78+
to load the installed firmware (e.g, reboot, power cycle, etc.) - this must be done manually by user
7579
7680
Note: in case immediate actions are required to complete the component firmware update
7781
(e.g., reboot, power cycle, etc.) - will be done automatically by API and no return value provided
@@ -86,11 +90,11 @@ def install_firmware(self, image_path):
8690

8791
def update_firmware(self, image_path):
8892
"""
89-
Updates firmware of the component.
93+
Updates firmware of the component
9094
9195
This API performs firmware update: it assumes firmware installation and loading in a single call.
92-
In case platform componet requires some extra steps (apart from calling Low Level Utility)
93-
to load the installed firmware (e.g, reboot, power cycle, etc.) - this will be done automatically by API.
96+
In case platform component requires some extra steps (apart from calling Low Level Utility)
97+
to load the installed firmware (e.g, reboot, power cycle, etc.) - this will be done automatically by API
9498
9599
Args:
96100
image_path: A string, path to firmware image

0 commit comments

Comments
 (0)