You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit f2304cd
Browse filesBrowse the repository at this point in the historyBrowse files
.Net: Replacing FunctionsView class with List (microsoft#2878)
### Motivation and Context
The `FunctionsView` class wraps two inner Dictionaries of `FunctionView`
objects: Native and Semantic. Since we no longer differentiate between
these two for any practical purpose, we could merge those into one list,
and we no longer need a special class for that.
### Description
- Removing the different collections to store Semantic vs Native
functions
- Removing `FunctionsView` collection
- From `SkillCollection.GetFunctionsView()`, returning an
`IReadOnlyList<FunctionView>`
- Callers can then easily use LINQ to filter the resulting flat list, or
group by skill name.
- Updating callers, tests
Resolvesmicrosoft#604
### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
- BREAKING CHANGE as it modifies the public API. Low impact.
---------
Co-authored-by: Roger Barreto <[email protected]>
Co-authored-by: Lee Miller <[email protected]>
0 commit comments