Node markdown generator tool unit tests#34
Node markdown generator tool unit tests#34SHKnudsen wants to merge 9 commits intoNode-Markdown-generator-toolfrom
Conversation
…tor-tool-unit-tests
|
@SHKnudsen thanks! 🎉 I think this PR is missing your because I am working on a version of your PR that removes the metadatacontext support I'll need to work through which tests work and which don't with that version of my PR. I don't think we can include all the revit dlls in the Dynamo repo so I don't think having a dependency on Revit will work for the test package - is it possible to write a regular ZT package that recreates some of the issues you were using Revit to test for? If you don't have bandwidth for that - thats fine. Maybe we can just chat about what issues were seen in DynamoRevitNodes that were not seen in the core nodes? |
|
@mjkkirschner I mainly did it for a package with Revit dependencies to also test that the reference paths worked. I can switch to a regular ZT package, I think there are a few in the test folder already. |
|
@SHKnudsen thanks, maybe just the DynamoSamples package or something like that? |
| { | ||
| internal static IEnumerable<FileInfo> DynamoDirectoryAssemblyPaths; | ||
| static void Main(string[] args) | ||
| private static IEnumerable<FileInfo> dynamoDirectoryAssemblyPaths; |
There was a problem hiding this comment.
curious about this change? Are you trying to make this faster?
There was a problem hiding this comment.
it was more so that we could unit test without Program.Main, the AssemblyHandler uses the dynamoDirectoryAssemblyPaths so if main hadn't been executed the assembly handler would fail here:
https://github.com/DynamoDS/Dynamo/pull/11725/files#diff-4ec66792a154bbfd3bc76223fc2de6df6a91cc71eebc43d29d427b0a96ada7a2R294
| "engine_version": "2.0.0", | ||
| "engine_metadata": "", | ||
| "engine": "dynamo", | ||
| "node_libraries": [ |
There was a problem hiding this comment.
hmm, were these changes necessary to get the package command to work?
There was a problem hiding this comment.
If so, would you mind also making the same change to the DynamoSamples repo? If we regen the sample package and then tests start failing it's going to be hard to figure out why.
There was a problem hiding this comment.
So the pkg json did not specify any node libraries, which I actually thought was required. So the package command would not know which assemblies to scan
There was a problem hiding this comment.
right - makes sense - there is some fallback behavior in dynamo for very old packages before node_libraries existed.
2 participants
Purpose
Adds unit tests for the commands used in the Markdown generator tool
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner
FYIs