Wire modifications- Unit Tests#28
Merged
M-JULIANI merged 63 commits intoSHKnudsen:wire-modifications-testsfrom Jul 29, 2021
M-JULIANI:Wire-Modifications-UnitTests
Merged
Wire modifications- Unit Tests#28M-JULIANI merged 63 commits intoSHKnudsen:wire-modifications-testsfrom M-JULIANI:Wire-Modifications-UnitTests
M-JULIANI merged 63 commits intoSHKnudsen:wire-modifications-testsfrom
M-JULIANI:Wire-Modifications-UnitTests
Conversation
… whether data passing through meets a requirement of 5 or more items.
… Need to implement a segmented version between pairs of pins.
…paque/halftone pins/watch icon depending on wire visibility.
…moved. Previously when removing pins the icon was drawn in the wrong place.
… existing codebase.
…hat of nodes). RaisePropertyChanged(nameof(Property)) throughout ConnectorViewModel.
This reverts commit 090fb18.
…IANI/Dynamo into Wire-Modifications" This reverts commit 23dc696, reversing changes made to 06378f0.
…ors thrown at the moment.
…) but rather have to be placed deliberately.
…Watch Node is placed. Previously they were discarded.
…ty. Got Undo/Redo functionality working partially.
…is placed." This reverts commit 18d2752.
SHKnudsen
requested changes
Jul 28, 2021
…king it. In any case 'model' is correct 'connectormodel ' is outdated.
8 tasks
SHKnudsen
pushed a commit
that referenced
this pull request
Jul 29, 2021
* Got hidden wire implementation working with View->ConnectorDisplay * Watch node behaviour modified. * Added image resources. Corrected hover/unhover of watch icon based on whether data passing through meets a requirement of 5 or more items. * WirePin: Model, ViewModel, View. Placeable/removable via ContextMenus. * Modified 'RunSharedParams' functionality to work properly. * Basic implementation of pins. Multi-control point bezier implemented. Need to implement a segmented version between pairs of pins. * Added WirePinViewModel discard functionality: DiscardAllWirePins() * Expected behaviour when deleting nodes (pins delete). Provision for opaque/halftone pins/watch icon depending on wire visibility. * Redrawing Watch (hover) icon at the midpoint when there are pins on the wire. * This fixes the 'WatchHoverIcon' when there are pins/ when they are removed. Previously when removing pins the icon was drawn in the wrong place. * Cleanup of unused code. * Clearup + pin highlighting behaviour. * Serialization/Deserialization of pins achieved. * 'Wire' to 'Connector' rename throughout for more consistency with the existing codebase. * Fixed unwanted duplicate pin placement (the one at the origin). * Discarded unused methods. Fixed pin multi-selection functionality. * Fixes to hidden wire display when pin selected. * Preview behaviour of wires fixed when a pin is selected (similar to that of nodes). RaisePropertyChanged(nameof(Property)) throughout ConnectorViewModel. * Basic implementation of 'Autolayout' which includes ConnectorPins. * Delete AssemblySharedInfo. * Remove unnecessary files/ file changes. * Delete unnecessary change. * Removed unnecessary files/file changes. * Delete unneeded change. * Revert "Delete unneeded change." This reverts commit 090fb18. * Revert "Merge branch 'Wire-Modifications' of https://github.com/M-JULIANI/Dynamo into Wire-Modifications" This reverts commit 23dc696, reversing changes made to 06378f0. * Reverted unneeded changes. * Reverting unneeded changes. * Removing unneeded changes. * Removing unneeded changes. * Unneeded changes. * Removed unneeded changes. * Removed unneeded changes. * Removed unneeded changes. * Removed unneeded changes. * Various PR fixes. * Reverted Resharper renaming of various comments. * PR fixes. * PR fixes. * ConnectorPin visibility fixed (follows Connector visibility). * Fixed PR issues. * Ironed out edge condition- AutoLayout _seems_ to work without any errors thrown at the moment. * PR Cleanup and Autolayout edge case fixes. * Ensures ConnectorPins cannot be copied and pasted (like notes & nodes) but rather have to be placed deliberately. * Functionality added to preserve pins when 'WatchIcon' is clicked and Watch Node is placed. Previously they were discarded. * Cleanup. * Added correct ConnectorPin icons for 'selected' and 'hidden' visibility. Got Undo/Redo functionality working partially. * Got 'undo' working for when a connector is pinned. * Undo/redo functionality between OOTB nodes and between custom nodes. * Cleanup. * Cleanup * Cleanup. * Viewmodel tests. * Added 'undo' unit tests. * Undo bug fixed. * Small logic changes to ConenctorPin placement when watchnode is placed. * Revert "Small logic changes to ConenctorPin placement when watchnode is placed." This reverts commit 18d2752. * Unit test PR modifications. * Undoing this change. * Nvm, reverted this. For some reason can't change it back without breaking it. In any case 'model' is correct 'connectormodel ' is outdated.
SHKnudsen
pushed a commit
that referenced
this pull request
Jul 29, 2021
* Got hidden wire implementation working with View->ConnectorDisplay * Watch node behaviour modified. * Added image resources. Corrected hover/unhover of watch icon based on whether data passing through meets a requirement of 5 or more items. * WirePin: Model, ViewModel, View. Placeable/removable via ContextMenus. * Modified 'RunSharedParams' functionality to work properly. * Basic implementation of pins. Multi-control point bezier implemented. Need to implement a segmented version between pairs of pins. * Added WirePinViewModel discard functionality: DiscardAllWirePins() * Expected behaviour when deleting nodes (pins delete). Provision for opaque/halftone pins/watch icon depending on wire visibility. * Redrawing Watch (hover) icon at the midpoint when there are pins on the wire. * This fixes the 'WatchHoverIcon' when there are pins/ when they are removed. Previously when removing pins the icon was drawn in the wrong place. * Cleanup of unused code. * Clearup + pin highlighting behaviour. * Serialization/Deserialization of pins achieved. * 'Wire' to 'Connector' rename throughout for more consistency with the existing codebase. * Fixed unwanted duplicate pin placement (the one at the origin). * Discarded unused methods. Fixed pin multi-selection functionality. * Fixes to hidden wire display when pin selected. * Preview behaviour of wires fixed when a pin is selected (similar to that of nodes). RaisePropertyChanged(nameof(Property)) throughout ConnectorViewModel. * Basic implementation of 'Autolayout' which includes ConnectorPins. * Delete AssemblySharedInfo. * Remove unnecessary files/ file changes. * Delete unnecessary change. * Removed unnecessary files/file changes. * Delete unneeded change. * Revert "Delete unneeded change." This reverts commit 090fb18. * Revert "Merge branch 'Wire-Modifications' of https://github.com/M-JULIANI/Dynamo into Wire-Modifications" This reverts commit 23dc696, reversing changes made to 06378f0. * Reverted unneeded changes. * Reverting unneeded changes. * Removing unneeded changes. * Removing unneeded changes. * Unneeded changes. * Removed unneeded changes. * Removed unneeded changes. * Removed unneeded changes. * Removed unneeded changes. * Various PR fixes. * Reverted Resharper renaming of various comments. * PR fixes. * PR fixes. * ConnectorPin visibility fixed (follows Connector visibility). * Fixed PR issues. * Ironed out edge condition- AutoLayout _seems_ to work without any errors thrown at the moment. * PR Cleanup and Autolayout edge case fixes. * Ensures ConnectorPins cannot be copied and pasted (like notes & nodes) but rather have to be placed deliberately. * Functionality added to preserve pins when 'WatchIcon' is clicked and Watch Node is placed. Previously they were discarded. * Cleanup. * Added correct ConnectorPin icons for 'selected' and 'hidden' visibility. Got Undo/Redo functionality working partially. * Got 'undo' working for when a connector is pinned. * Undo/redo functionality between OOTB nodes and between custom nodes. * Cleanup. * Cleanup * Cleanup. * Viewmodel tests. * Added 'undo' unit tests. * Undo bug fixed. * Small logic changes to ConenctorPin placement when watchnode is placed. * Revert "Small logic changes to ConenctorPin placement when watchnode is placed." This reverts commit 18d2752. * Unit test PR modifications. * Undoing this change. * Nvm, reverted this. For some reason can't change it back without breaking it. In any case 'model' is correct 'connectormodel ' is outdated.
SHKnudsen
pushed a commit
that referenced
this pull request
Jul 29, 2021
* Got hidden wire implementation working with View->ConnectorDisplay * Watch node behaviour modified. * Added image resources. Corrected hover/unhover of watch icon based on whether data passing through meets a requirement of 5 or more items. * WirePin: Model, ViewModel, View. Placeable/removable via ContextMenus. * Modified 'RunSharedParams' functionality to work properly. * Basic implementation of pins. Multi-control point bezier implemented. Need to implement a segmented version between pairs of pins. * Added WirePinViewModel discard functionality: DiscardAllWirePins() * Expected behaviour when deleting nodes (pins delete). Provision for opaque/halftone pins/watch icon depending on wire visibility. * Redrawing Watch (hover) icon at the midpoint when there are pins on the wire. * This fixes the 'WatchHoverIcon' when there are pins/ when they are removed. Previously when removing pins the icon was drawn in the wrong place. * Cleanup of unused code. * Clearup + pin highlighting behaviour. * Serialization/Deserialization of pins achieved. * 'Wire' to 'Connector' rename throughout for more consistency with the existing codebase. * Fixed unwanted duplicate pin placement (the one at the origin). * Discarded unused methods. Fixed pin multi-selection functionality. * Fixes to hidden wire display when pin selected. * Preview behaviour of wires fixed when a pin is selected (similar to that of nodes). RaisePropertyChanged(nameof(Property)) throughout ConnectorViewModel. * Basic implementation of 'Autolayout' which includes ConnectorPins. * Delete AssemblySharedInfo. * Remove unnecessary files/ file changes. * Delete unnecessary change. * Removed unnecessary files/file changes. * Delete unneeded change. * Revert "Delete unneeded change." This reverts commit 090fb18. * Revert "Merge branch 'Wire-Modifications' of https://github.com/M-JULIANI/Dynamo into Wire-Modifications" This reverts commit 23dc696, reversing changes made to 06378f0. * Reverted unneeded changes. * Reverting unneeded changes. * Removing unneeded changes. * Removing unneeded changes. * Unneeded changes. * Removed unneeded changes. * Removed unneeded changes. * Removed unneeded changes. * Removed unneeded changes. * Various PR fixes. * Reverted Resharper renaming of various comments. * PR fixes. * PR fixes. * ConnectorPin visibility fixed (follows Connector visibility). * Fixed PR issues. * Ironed out edge condition- AutoLayout _seems_ to work without any errors thrown at the moment. * PR Cleanup and Autolayout edge case fixes. * Ensures ConnectorPins cannot be copied and pasted (like notes & nodes) but rather have to be placed deliberately. * Functionality added to preserve pins when 'WatchIcon' is clicked and Watch Node is placed. Previously they were discarded. * Cleanup. * Added correct ConnectorPin icons for 'selected' and 'hidden' visibility. Got Undo/Redo functionality working partially. * Got 'undo' working for when a connector is pinned. * Undo/redo functionality between OOTB nodes and between custom nodes. * Cleanup. * Cleanup * Cleanup. * Viewmodel tests. * Added 'undo' unit tests. * Undo bug fixed. * Small logic changes to ConenctorPin placement when watchnode is placed. * Revert "Small logic changes to ConenctorPin placement when watchnode is placed." This reverts commit 18d2752. * Unit test PR modifications. * Undoing this change. * Nvm, reverted this. For some reason can't change it back without breaking it. In any case 'model' is correct 'connectormodel ' is outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Make sure to merge #23 prior to reviewing this PR.
Purpose
This separate PR includes the unit testing for the following PR: #23.
Description
This PR includes unit tests for Wire Behaviour functionality. It is a separate PR for clarity of scope. PR #23 needs to be merged prior to this PR being merged.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@SHKnudsen
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of