Add type definitions for bottleneck/light#160
Merged
SGrondin merged 1 commit intoSGrondin:masterfrom Jul 21, 2020
Merged
Conversation
SGrondin
approved these changes
Jul 21, 2020
Owner
|
I'll make a new release tonight |
|
Hey Simon, could you do the release please? |
|
Hi @SGrondin, I was walking through existing open issues in Octokit and I arrived to an issue which depends on these changes to be released, what's the status of Thanks for your time and please let us know if you need help. |
|
@SGrondin it looks like there is still no new release. Could you please do a new release that includes this fix? |
lmk123
added a commit
to hcfyapp/bottleneck
that referenced
this pull request
Jun 26, 2025
|
I merged this PR into my fork and published it to npm. Source code: https://github.com/hcfyapp/bottleneck Install: Then import: import Bottleneck from '@hcfy/bottleneck/light' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there, octokit/plugin-retry.js uses
bottleneck/lightfor ratelimiting, but there's a little bit of trouble importing types when usingbottleneck/lightover the mainbottleneckimport.I did some testing and adding a
light.d.tsdefinition file with existing namespace and class types but under abottleneck/lightmodule lets typescript find the types for the light import.I noticed that the existing type definitions were using EJS templates, so I move the namespace and class type definitions to a shared EJS template and included that in both the bottleneck.d.ts.ejs and light.d.ts.ejs template files.
This fixes the issue in octokit/plugin-retry.js#110, but I'm open to suggestions if there's a better way to do this!