Fall back to using the NULL audio backend if the default backends don't provide any devices.#2966
Merged
Merged
Conversation
…'t provide any devices.
Collaborator
Pull Request Test Coverage Report for Build 8886478280Details
💛 - Coveralls |
Member
|
I rebased my tests onto this PR and we're still getting Linux and Windows CI failures. It did fix the macOS issues though. |
eXpl0it3r
approved these changes
May 14, 2024
Member
|
Seems to work fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title.
Because audio context creation will succeed even if the selected context cannot provide any devices, the NULL backend is never selected even on systems on which we know no audio device exists. We have to check for the existence of devices ourselves after creating a normal context and force miniaudio to create a NULL context if we determine a normal context would not provide us with any devices.
Should help with testing on audio device-less systems such as when running CI.