Silence new clang-tidy-18 checks#2953
Merged
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 8794075855Details
💛 - Coveralls |
eXpl0it3r
approved these changes
Apr 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As of earlier today Homebrew is now shipping Clang 18 and clang-tidy-18. This includes a number of new clang-tidy checks that SFML currently does not abide by so we need to silence them as soon as possible to allow CI to continue to pass. I'm not yet sure if I want to enable any of these new checks but I might do that later.
I reran CI on
masterto demonstrate this failure: https://github.com/SFML/SFML/actions/runs/8793914308