Allows easy to use WebImage with isAnimating default to false and change to true later#333
Merged
dreampiggy merged 1 commit intomasterfrom Aug 29, 2024
Merged
Conversation
…hange to true later Since SDAnimatedImage has fallback logic, we can apply this to WebImage by default without dynamic check
dreampiggy
force-pushed
the
bugfix/webimage_isAnimating_binding
branch
from
1b68c49 to
7efdf22
Compare
|
I tested this branch in my app; it works perfectly for me and fixes #332. Thanks for the quick fix! |
This was referenced Aug 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason
Since SDAnimatedImage has fallback logic, we can apply this to WebImage by default without dynamic check
This close #332