Skip to content

Allows to use UIImage/NSImage as defaults when init the AnimatedImage with JPEG data#277

Merged
dreampiggy merged 3 commits intomasterfrom
bugfix/jpeg_animatedimage_data
Oct 21, 2023
Merged

Allows to use UIImage/NSImage as defaults when init the AnimatedImage with JPEG data#277
dreampiggy merged 3 commits intomasterfrom
bugfix/jpeg_animatedimage_data

Conversation

@dreampiggy
Copy link
Copy Markdown
Collaborator

This match the behavior when passing with the JPEG url initializer

This close SDWebImage/SDWebImage#3625

@dreampiggy dreampiggy added the animated image AnimatedImage struct label Oct 21, 2023
… with JPEG data

This match the behavior when passing with the JPEG url initializer
@dreampiggy dreampiggy force-pushed the bugfix/jpeg_animatedimage_data branch from 07fcee4 to 5009333 Compare October 21, 2023 08:25
@dreampiggy
Copy link
Copy Markdown
Collaborator Author

@hstdt Does this fix your issue ? We can release a new beta version.

Or if you want the 2.x (This 3.x changes the API of WebImage/AnimatedImage to match Apple's AsyncImage). We can backport this commits and release another 2.x version

@dreampiggy
Copy link
Copy Markdown
Collaborator Author

dreampiggy commented Oct 21, 2023

@hstdt Released both v2.2.4 version as well as the 3.0.0-beta.2 (Which drop iOS 13 and use AsyncImage like API)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

animated image AnimatedImage struct

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JPG image data is not visible with SDAnimatedImage(data:)/AnimatedImage(data:)(SwiftUI) while png data works fine

1 participant