fix transition not working#248
Closed
wishWinds wants to merge 2 commits intoSDWebImage:masterfrom
Closed
Conversation
Collaborator
|
I don't think add this into a ObservedObject is suitable... The correct way maybe put this |
Author
|
It may has no way to trigger animation within Thanks. |
|
Thank you |
|
Any updates on this? |
|
any update? transition still broken |
|
I found a workaround here: #272 |
|
why did you close the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix transition modifier not working.
The side effect is transition will always animate even if image is load from memory or disk cache.