fix: sd_colorAtPoint/sd_colorsWithRect should early return when pixel format is not supported#3798
Merged
dreampiggy merged 2 commits intoFeb 22, 2025
Conversation
dreampiggy
force-pushed
the
bugfix/sd_colorAtPoint_early_return
branch
from
February 22, 2025 09:21
67c3453 to
e332544
Compare
dreampiggy
force-pushed
the
bugfix/sd_colorAtPoint_early_return
branch
2 times, most recently
from
February 22, 2025 09:33
36ff532 to
9a312ca
Compare
Contributor
Author
|
In the future, we may support RGBA16 or RGBAF, but this needs more testing and I doubt how many user need this API |
dreampiggy
force-pushed
the
bugfix/sd_colorAtPoint_early_return
branch
from
February 22, 2025 09:38
9a312ca to
207a03c
Compare
dreampiggy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)This merge request fixes / refers to the following issues: ...
Pull Request Description
In previous version, when using RGB16/RGBA10, these method may return a non-nil but not correct
UIColor, which may cause more complicated issue and hard to detect.Now, we just return nil and log the error, to let user know it's not supported