Fix the issue that previous optimization for special case (multiple same URL in prefetcher list) breaks the queryCacheType option sematic#3788
Merged
dreampiggy merged 4 commits intoFeb 14, 2025
Conversation
…ame URL in prefetcher list) breaks the `queryCacheType` option sematic We should only do optimization on `async` disk cache query case
dreampiggy
force-pushed
the
bugfix/cache_query_type_optimization
branch
from
January 27, 2025 11:54
a755115 to
066163f
Compare
…ry from disk only semantic
dreampiggy
force-pushed
the
bugfix/cache_query_type_optimization
branch
from
January 27, 2025 12:13
b9f7757 to
3797c8c
Compare
dreampiggy
force-pushed
the
bugfix/cache_query_type_optimization
branch
6 times, most recently
from
February 14, 2025 08:58
b807885 to
5f5daf5
Compare
Update the test case url, that wikipedia url seems strange on iOS unit test
dreampiggy
force-pushed
the
bugfix/cache_query_type_optimization
branch
2 times, most recently
from
February 14, 2025 09:20
15b178d to
b1aa646
Compare
dreampiggy
force-pushed
the
bugfix/cache_query_type_optimization
branch
from
February 14, 2025 09:26
b1aa646 to
3257ea2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)This merge request fixes / refers to the following issues: ...
Pull Request Description
This fix the regression because of #3523
To optimize this case, we add a
second memory cache checkduring the async disk cache query logic, but this logic should follows the same requirement as thefirst memory cache checkI copy the
// First check the in-memory cache...comment 3 times to mention that these code should follows the same logic