Deprecate dispatch_main_async_safe, introduce two more policy .safeAsyncMainThread (for UIKit diffable data source) and .safeAsyncMainQueue (for most common cases)#3766
Merged
dreampiggy merged 4 commits intoFeb 20, 2025
Conversation
…SDCallbackQueue and may callback in non-main queue
dreampiggy
force-pushed
the
bugfix/uiview_webcache_sdcallbackqueue
branch
from
November 11, 2024 09:23
f9f14cf to
9db39a4
Compare
…for UI-related code logic Handled two cases in real-world app
dreampiggy
force-pushed
the
bugfix/uiview_webcache_sdcallbackqueue
branch
from
November 11, 2024 09:43
9db39a4 to
ed1f0f8
Compare
This used for user who really need `mainThread` but not `mainQueue`
dreampiggy
changed the title
.safeAsyncMainThread and .safeAsyncMainQueue for different use case
…e `SafeAsyncMainQueue`, others revert back to default value The implementation don't need complicated check, using object compare is enough
dreampiggy
force-pushed
the
bugfix/uiview_webcache_sdcallbackqueue
branch
from
November 14, 2024 13:35
64f9ffb to
b4c741a
Compare
Contributor
Author
|
Some one point this that we should always use So what's the real correct way ? Why the SDWebImage original author use |
dreampiggy
changed the title
.safeAsyncMainThread and .safeAsyncMainQueue for different use case.safeAsyncMainThread and .safeAsyncMainQueue for different use case, and defaults to MainThread
dreampiggy
changed the title
.safeAsyncMainThread and .safeAsyncMainQueue for different use case, and defaults to MainThread.safeAsyncMainThread (for UIKit diffable data source) and .safeAsyncMainQueue (for most common cases)
Contributor
Author
TLDRFor normal image loading, we use For |
This was referenced Feb 20, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)This merge request fixes / refers to the following issues: ...
Pull Request Description
This close #3765