Skip to content

Expose the data and format when SDAnimatedImageRep created with APNG/GIF/WebP/HEICS#3573

Merged
dreampiggy merged 2 commits intoSDWebImage:masterfrom
dreampiggy:feature/keep_animated_data_macOS_imageRep
Jul 27, 2023
Merged

Expose the data and format when SDAnimatedImageRep created with APNG/GIF/WebP/HEICS#3573
dreampiggy merged 2 commits intoSDWebImage:masterfrom
dreampiggy:feature/keep_animated_data_macOS_imageRep

Conversation

@dreampiggy
Copy link
Copy Markdown
Contributor

@dreampiggy dreampiggy commented Jul 26, 2023

New Pull Request Checklist

  • I have read and understood the CONTRIBUTING guide

  • I have read the Documentation

  • I have searched for a similar pull request in the project and found none

  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

  • I have added the required tests to prove the fix/feature I am adding

  • I have updated the documentation (if necessary)

  • I have run the tests and they pass

  • I have run the lint and it passes (pod lib lint)

This merge request fixes / refers to the following issues: ...

Pull Request Description

This can avoid extra re-encoding (slow) for some cases if you need compressed image data, on macOS AppKit

Used in AVIFQuickLook or some other cases

@dreampiggy dreampiggy changed the title Expose the data and format when SDAnimatedImage created with APNG/GIF/WebP/HEICS Expose the data and format when SDAnimatedImageRep created with APNG/GIF/WebP/HEICS Jul 26, 2023
…GIF/WebP/HEICS

This can avoid extra decoding (slow) for some cases if you need compressed image data
@dreampiggy dreampiggy force-pushed the feature/keep_animated_data_macOS_imageRep branch from c4a11ba to 169cd64 Compare July 26, 2023 15:02
@dreampiggy dreampiggy force-pushed the feature/keep_animated_data_macOS_imageRep branch from 169cd64 to 480f3b5 Compare July 26, 2023 15:04
@dreampiggy dreampiggy added the macOS AppKit for macOS label Jul 26, 2023
@dreampiggy dreampiggy added this to the 5.18.0 milestone Jul 27, 2023
@dreampiggy dreampiggy merged commit bc4d0c7 into SDWebImage:master Jul 27, 2023
@dreampiggy dreampiggy deleted the feature/keep_animated_data_macOS_imageRep branch July 27, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macOS AppKit for macOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant