(Part 1) Support to build for visionOS (no package manager support)#3556
Merged
dreampiggy merged 2 commits intoSDWebImage:masterfrom Sep 2, 2023
Merged
(Part 1) Support to build for visionOS (no package manager support)#3556dreampiggy merged 2 commits intoSDWebImage:masterfrom
dreampiggy merged 2 commits intoSDWebImage:masterfrom
Conversation
dreampiggy
force-pushed
the
feature/visionOS
branch
from
143d20c to
7d97092
Compare
dreampiggy
commented
Jun 25, 2023
dreampiggy
commented
Jun 25, 2023
|
Looks like you need to use TARGET_OS_VISION instead of TARGET_OS_XR in the latest betas. |
scottsykora
reviewed
Aug 30, 2023
Contributor
Author
|
Recently I still has no much more time on SDWebImage open source project. So I deceide to separete the visionOS into 2 parts.
The part 1 will merged into 5.x, which does not require you to use Xcode 15, so you can still use Xcode 14/13 to build SDWebImage. For 6.0.0, Xcode 15 is required |
dreampiggy
changed the title
dreampiggy
force-pushed
the
feature/visionOS
branch
from
7d97092 to
afaae99
Compare
The scale using traitCollection.displayScale This only change source code
dreampiggy
force-pushed
the
feature/visionOS
branch
from
afaae99 to
9704385
Compare
Contributor
Author
|
Tested can be compiled on visionOS 1.0 with Xcode 15 Beta 7 
And, does not break the exists Xcode 14 toolchain users |
dreampiggy
force-pushed
the
feature/visionOS
branch
from
9704385 to
8000e23
Compare
dreampiggy
changed the title
Contributor
Author
|
available in 5.18.0 I don't think CocoaPods and SwiftPM is ready for this, or I don't think the package manager can supports both Xcode 15 and Xcode 14. At least SwiftPM does not, when you add |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)This merge request fixes / refers to the following issues: ...
Pull Request Description
See:
https://twitter.com/DreamingPiggy/status/1671841279205076992?s=20