Skip to content

Conversation

@jbadan
Copy link
Contributor

@jbadan jbadan commented Apr 20, 2020

Description

Update the components we missed in the previous iteration to use the new validation states.

NOTE: these will eventually need to be migrated to use _ValidationOverlay and validationState

Breaking change:

  1. proptype: state: options for Checkbox, FormRadioItem, FormSelect, FormTextArea updated to new list: error, warning, success, information
  2. Removed children proptype from FormTextArea as that usage is not valid html

fixes #953

@jbadan jbadan changed the title feat: forms feat: forms using state proptype migrated to updated options Apr 20, 2020
@jbadan jbadan requested a review from a team April 20, 2020 19:30
@netlify
Copy link

netlify bot commented Apr 20, 2020

@netlify
Copy link

netlify bot commented Apr 20, 2020

Copy link
Contributor

@skvale skvale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbadan jbadan merged commit 0aea9bd into master Apr 21, 2020
@jbadan jbadan deleted the fix/text-area branch April 21, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FormTextarea invalid states

2 participants