Skip to content

feat: update fundamental-styles to 0.6.0-rc.26 #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbadan wants to merge 29 commits into from
Closed

feat: update fundamental-styles to 0.6.0-rc.26 #888

jbadan wants to merge 29 commits into from

Conversation

@jbadan
Copy link
Contributor

@jbadan jbadan commented Feb 28, 2020

Description

This is a continuation of #885

I'm opening these so that reviewers can see the changes in "smaller" increments. There will a final pr to review with the final changes. Feel free to leave comments here though.

  • Tab
    • remove disabled prop
  • Shellbar
    • logo <a> is now <span>
    • added <div> around Identifier component
  • Alert
    • renamed MessageStrip
    • classname changes
    • removed Icon from underlying html
  • Dropdown
    • renamed Select
    • remove standard prop
  • ListGroup
    • renamed “List”
    • classname changes
    • so many changes! basically a new component!
  • MultiInput
    • underlying html changes
    • Popover body now built with List component
    • lots of underlying html changes for validation states
    • state prop replaced with validationState - takes object
    • localizedText prop removed
  • Combobox Input
    • underlying html changes
    • menu prop renamed list - now takes List component
    • state prop now validationState - takes an object
  • FormMessage
    • now a <div> from <span>
  • InputGroup
    • state prop now validationState - takes an object
    • underlying html changes to include FormMessage when passed validationState
  • SearchInput
    • state prop now validationState - takes an object
    • underlying html changes to include FormMessage when passed validationState
  • FormLabel
    • removed isToggle prop
  • Toggle
    • renamed to “Switch”
    • removed size options, now use compact property
    • labelProps no longer needed, additional props will be spread to the <label> element
    • underlying html changes - no longer wrapped in FormItem

@jbadan jbadan added the WIP Work in Progress label Feb 28, 2020
@netlify
Copy link

netlify bot commented Feb 28, 2020

Deploy preview for fundamental-react ready!

Built with commit 3304611

https://deploy-preview-888--fundamental-react.netlify.com

@netlify
Copy link

netlify bot commented Feb 28, 2020

Deploy preview for fundamental-react ready!

Built with commit dbcf2f3

https://deploy-preview-888--fundamental-react.netlify.com

@netlify
Copy link

netlify bot commented Feb 28, 2020

Deploy preview for fundamental-react ready!

Built with commit 9fd684b

https://deploy-preview-888--fundamental-react.netlify.com

skvale
skvale reviewed Feb 28, 2020
View reviewed changes
src/ComboboxInput/ComboboxInput.js
</FormMessage>
{list}
</>
) : list}
Copy link
Contributor

@skvale skvale Feb 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a tiny bit cleaner to me

<>
  {validationState && 
    <FormMessage
      disableStyles={disableStyles}
      type={validationState.state}>
        {validationState.text}
    </FormMessage>
  }
  {list}
</>

@jbadan
Copy link
Contributor Author

jbadan commented Feb 28, 2020

Known Issues:
* Toggle/Switch
* internalLabel prop not working in prop descriptions
* not an accessible pattern
* this is going to change ASAP as it is currently being redesigned
* icons are misaligned inside switch
* Token:
* selected state - did not implement - what is this even used for?
* Shellbar
* see screenshot - fd-shellbar__button needs more specificity
* ListText
* —no-wrap class only works in selects
* Select
* compact not working because —fd-forms-height-compact is not part of our postcss pipeline anymore - just SAP variables
* MultiInput
* fd-tokenizer__input does not take priority over fd-input - getting the fd-input outline box (needs more specificity)
* Validation states
* validation state styling - FS has the validation message as a list item instead of a div

@jbadan jbadan closed this Feb 28, 2020
@jbadan jbadan mentioned this pull request Feb 28, 2020
Merged
@jbadan jbadan deleted the feat/update-fs-6 branch April 26, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@skvale skvale skvale left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

WIP Work in Progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jbadan @skvale @meganaconley