Skip to content

Conversation

@jbadan
Copy link
Contributor

@jbadan jbadan commented Feb 26, 2020

Description

Separating these out when I hit good stopping points.

  • Checkbox
    • new children prop
    • value prop changed
    • underlying html has changed significantly
  • FormRadioItem
    • underlying html has changed significantly
  • FormMessage
    • now an internal component
  • FormInput
    • removed state property
    • new validationState property
  • FormItem
    • remove isHorizontal prop
    • remove isInline prop (was internal only)
  • FormRadioGroup
    • now outputs <div> instead of Fragment
  • FormLabel
    • remove isCheckbox prop
    • remove isRadio prop

@jbadan jbadan requested a review from a team February 26, 2020 00:35
@netlify
Copy link

netlify bot commented Feb 26, 2020

@jbadan jbadan added the WIP Work in Progress label Feb 28, 2020
@jbadan jbadan closed this Feb 28, 2020
jbadan added a commit that referenced this pull request Mar 2, 2020
Modal
   - renamed `Dialog`
   - removed `closeProps`
   - `actions` now required
Button
   - underlying class name changes
ButtonGroup
   - classname changed to `fd-segmented-button`
- Tab
    - remove `disabled` prop
   - change underlying html - added `span` around tab text
- Shellbar
    - logo `<a>` is now `<span>`
    - added `<div>` around Identifier component
- Alert
    - renamed MessageStrip
    - classname changes 
    - removed Icon from underlying html
- Dropdown
    - renamed `Select`
    - remove `standard` prop
- ListGroup
    - renamed “List”
    - classname changes
    - so many changes! basically a new component!
- MultiInput
    - underlying html changes
    - `Popover` body now built with `List` component
    - lots of underlying html changes for validation states
    - `state` prop replaced with `validationState` - takes object
    - `localizedText` prop removed
- Combobox Input
    - underlying html changes
    - `menu` prop renamed `list` - now takes `List` component
    - `state` prop now `validationState` - takes an object 
- FormMessage
    - now a `<div>` from `<span>`
- InputGroup
    - `state` prop now `validationState` - takes an object
    - underlying html changes to include `FormMessage` when passed `validationState`
- SearchInput
    - `state` prop now `validationState` - takes an object
    - underlying html changes to include `FormMessage` when passed `validationState`#885
- Toggle
    - renamed to “Switch”
    - removed size options, now use `compact` property
    - `labelProps` no longer needed, additional props will be spread to the `<label>` element
    - underlying html changes - no longer wrapped  in `FormItem`
* Checkbox
    * new `children` prop
    * `value` prop changed
    * underlying html has changed significantly 
* FormRadioItem
    * underlying html has changed significantly 
* FormMessage
    * now an internal component
* FormInput
    * removed `state` property
    * new `validationState` property
* FormItem
    * remove `isHorizontal` prop
    * remove `isInline` prop (was internal only)
* FormRadioGroup
    * now outputs `<div>` instead of Fragment
* FormLabel
    * remove `isCheckbox` prop
    * remove `isRadio` prop
    - removed `isToggle` prop
@jbadan jbadan deleted the fix/update-fs-rc25 branch April 26, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WIP Work in Progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants