feat: update to [email protected] #848
Conversation
|
Deploy preview for fundamental-react ready! Built with commit 247ee9d |
src/Button/Button.Component.js
Outdated
| Disabled | ||
| </Button> | ||
| </div> | ||
| <div className='frDocs-tile__break' /> |
There was a problem hiding this comment.
An extra <div className='frDocs-tile__break' /> here
| children: PropTypes.node, | ||
| className: PropTypes.string, | ||
| compact: PropTypes.bool, | ||
| condensed: PropTypes.bool, |
There was a problem hiding this comment.
Will need prop descriptions for condensed, isUtility, and level
|
@jacobdevera No, it's not just you. When the side nav collapses and it shown via the hamburger menu, it no longer scrolls. |
greg-a-smith
left a comment
greg-a-smith
left a comment
There was a problem hiding this comment.
I am seeing this weirdness on the Button page regardless of how wide I make the browser window.
src/Calendar/Calendar.js
Outdated
| weekDays.push( | ||
| <th className='fd-calendar__column-header' key={index}> | ||
| <span className='fd-calendar__day-of-week'> | ||
| <span className='fd-calendar__day-of-week' role='button'> |
There was a problem hiding this comment.
Why do the days of the week have a role of button? They aren't actually clickable, are they?
| children: PropTypes.node, | ||
| className: PropTypes.string, | ||
| compact: PropTypes.bool, | ||
| condensed: PropTypes.bool, |
There was a problem hiding this comment.
Needs a prop description.
|
Related to the side-nav not scrolling from previous comments, the scrollbar changed elements master branch
this branch
|
|
@skvale That's actually part of this PR's change. The Side Navigation component (which is what the site's left nav is built with) has been refactored and is now using different classes. |
|
New commit fixes:
|
|
@meganaconley The PR feedback changes looked good except for the side nav scrolling. It did scroll this time, however, now even the search box scrolled with it -- that is supposed to stay fixed. Instead of more comments and screenshots, I contributed a few changes. I set the sidebar width to |
greg-a-smith
left a comment
greg-a-smith
left a comment
There was a problem hiding this comment.
Assuming the build passes, these changes look good. I am part author now so I'll give it a partial ⛵️. If my contributions look good, feel free to approve and merge.
|
Thanks for the help @greg-a-smith! |
5 participants
Description
[BREAKING CHANGE]
Updates fundamental-styles to 0.4.0-rc.3, bringing in the following markup changes:
SideNavrefactornested-liststyles and structureutilitynavButtonchangesmediumbutton removedCalendarchangesultotable