feat: update fundamental-styles to 0.3.0 #846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-react ready! Built with commit da83d8b |
jbadan
reviewed
Jan 9, 2020
| MenuList.displayName = 'Menu.List'; | ||
|
|
||
| MenuList.propTypes = { | ||
| addonBefore: PropTypes.bool, |
Contributor
There was a problem hiding this comment.
Can you add separated and addonBefore to the prop description list.
jbadan
reviewed
Jan 9, 2020
jbadan
reviewed
Jan 9, 2020
jbadan
requested changes
Jan 9, 2020
Contributor
jbadan
left a comment
jbadan
left a comment
There was a problem hiding this comment.
Looks good - just a few small changes :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[BREAKING CHANGE]
First in a series of PRs to catch up fundamental-styles. The primary changes in this set that are relevant to fundamental-react (up to 0.3.0) were markup changes to the Menu and Shellbar ProductSwitch components.
separatorprop and<hr>removed fromMenuItemseparatedprop added toMenuListaddonBeforeprop passed down intoMenuItemin order to renderaddonspanaddonnode changed tospanand is now wrapped within theaProductSwitcherrenamed toProductSwitchProductSwitchcss filenavnode fromProductSwitchProductSwitchProductListinstead of imagesKnown issues
ProductSwitchbutton inShellbarhas a white background. Further PRs to catch up onButtonclassname changes will fix the issue.A new component was added which is out of scope for this PR. Issue #821 has already been created for the new Notification component.
https://github.com/SAP/fundamental-styles/blob/master/CHANGELOG.md
Two more PRs are planned to bring it up to 0.3.1 and then 0.4.0-rc.3 to unblock calendar a11y work.