feat: allow adding classes to both modal body (removing extraneous div) and backdrop #845
Conversation
|
Deploy preview for fundamental-react ready! Built with commit 6259515 |
src/Modal/Modal.js
Outdated
| ); | ||
|
|
||
| const modalClasses = classnames( | ||
| 'modal-demo-bg', |
There was a problem hiding this comment.
I know this class was here before, but should it be? This seems like something used as a selector for unit tests and there is an entry in customstyles.css from fundamental-styles. It's fine to use some custom styles for a playground or such, but it shouldn't be part of the base component's classes.
There was a problem hiding this comment.
Good catch! I'll remove it
There was a problem hiding this comment.
@greg-a-smith turns out that entire div was just for the styles docs site. I'm removing it here and going to make a pr there to make that more obvious.
jbadan
changed the title
|
@jbadan Although this is a feature, should the prefix be |
|
I did |
|
@jbadan Yeah, fair enough. I forgot about that. 👍 |
3 participants
Description
Copy of #824, removing commit
01a4c6cthat causes publishing issues.fixes #800