feat: allow adding classes to both modal body and backdrop #816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
Wawrzyn321
changed the title
|
Deploy preview for fundamental-react ready! Built with commit 4d29504 |
jbadan
approved these changes
Dec 5, 2019
jacobdevera
added a commit
that referenced
this pull request
Dec 17, 2019
* fix: use momentjs * fix: next/prev handling * feat: allow adding classes to both modal body and backdrop (#816) BREAKING CHANGE: * removed className prop, new className props * chore(release): version 1.0.0-rc.0 build 3065 [ci skip] * fix: use moment in datepicker * fix: simplify derived state logic * fix: simplify enabled date logic * fix: simplify validation logic * fix: tests * fix: localization * fix: increase size limit * fix: use date objects for props * chore: calendar stories * chore: datepicker stories * chore: locale * merge * fix: unnecessary diffs * fix: visual regression testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modalby allowing the user to add CSS classes to modal body. Previously, it was possible to add the class only to the backdrop. It could be worked around as described here.classNametobackdropClassNameto avoid confusion.fixes #800