feat: add accessibility features to popover control #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Deploy preview for fundamental-react ready! Built with commit 4d53062 |
prsdthkr
reviewed
Nov 14, 2019
Member
prsdthkr
left a comment
prsdthkr
left a comment
There was a problem hiding this comment.
Generally the onKeyPress works well with simple Popover controls. It gets a bit tricky with complex controls like ComboboxInput, LocalizationEditor, SearchInput because they have additional input and button within.
Contributor
|
Once the Popover is open - how do I navigate inside of it with keyboard? Or is that out of scope for this pr.
|
Contributor
prsdthkr
reviewed
Nov 19, 2019
prsdthkr
approved these changes
Nov 19, 2019
Member
prsdthkr
left a comment
prsdthkr
left a comment
There was a problem hiding this comment.
✅ QA looks good to me on Chrome with VoiceOver.
jacobdevera
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add accessibility features to the
Popovercontrolprop. This way, any element can be passed as a control, but it will still work as a button.tabIndex: puts normally non-tabbable elements into the normal tab flowaria-haspopup: indicates the button triggers a popuprole="button": screenreader will announce element as buttononKeyPresshandler: if thecontrolis not a button, addsenterandspaceas a way to trigger the popover.