Repository navigation
Implement webcam switching and shortcut disable feature - #6
Merged
Merged
Conversation
Owner
|
Thanks, bro. What you've done is really cool, but I need to make some adjustments to your code before merging this PR, probably in the next few days. |
RylanBot
force-pushed
the
main
branch
2 times, most recently
from
March 17, 2024 11:29
bf2c753 to
c35179b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug related to the keyboard layout. Previously, the shortcut key combination was set using event.key from the Keyboard Event, which returns the character generated by pressing the key. I replaced this with processing event.code, which isn't altered by the keyboard layout or the state of the modifier keys. One known bug that persists is that the robotjs library doesn't process keys correctly when any keyboard layout other than English QWERTY is set for the Electron process.