Skip to content

Commit f43f6dd

Browse files
SunkenInTimeclaude
andauthored
fix(web): even 4px inset around rows in the PR badge tooltip (pingdotgg#18352)
Co-authored-by: Claude Opus 5.5 <[email protected]>
1 parent 1d270be commit f43f6dd

1 file changed

Lines changed: 18 additions & 14 deletions

File tree

‎apps/web/src/components/ThreadStatusIndicators.tsx‎

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -316,22 +316,26 @@ function PullRequestBadge({
316316
variant="glass"
317317
className="pointer-events-auto w-80 max-w-[calc(100vw-2rem)] text-left whitespace-normal"
318318
>
319-
{visibleThreadPullRequests(pullRequests).length > 0 ? (
320-
<ThreadPullRequestsMiniList
321-
pullRequests={pullRequests}
322-
onOpenPullRequest={onOpenPullRequest}
323-
/>
324-
) : number !== undefined && url !== undefined ? (
325-
<ul className="flex flex-col gap-1">
326-
<ThreadPullRequestMiniListItem
327-
number={number}
328-
url={url}
329-
title={status?.tooltipTitle ?? presentation.label}
330-
presentation={presentation}
319+
{/* The viewport pads 8px inline and 4px block; pull the rows out so their hover
320+
highlight sits 4px from every edge. */}
321+
<div className="-mx-1">
322+
{visibleThreadPullRequests(pullRequests).length > 0 ? (
323+
<ThreadPullRequestsMiniList
324+
pullRequests={pullRequests}
331325
onOpenPullRequest={onOpenPullRequest}
332326
/>
333-
</ul>
334-
) : null}
327+
) : number !== undefined && url !== undefined ? (
328+
<ul className="flex flex-col gap-1">
329+
<ThreadPullRequestMiniListItem
330+
number={number}
331+
url={url}
332+
title={status?.tooltipTitle ?? presentation.label}
333+
presentation={presentation}
334+
onOpenPullRequest={onOpenPullRequest}
335+
/>
336+
</ul>
337+
) : null}
338+
</div>
335339
</TooltipPopup>
336340
</Tooltip>
337341
);

0 commit comments

Comments
 (0)