@@ -1576,6 +1576,9 @@ function toCheckStatus(raw: Schema.Schema.Type<typeof RawCheckSchema>): PullRequ
15761576/** What GitHub writes where a run has not reached that moment yet, which is not a time. */
15771577const UNSET_TIMESTAMP = "0001-01-01T00:00:00Z" ;
15781578
1579+ /** Sorts after every real timestamp, so the deduper keeps a run that has not finished. */
1580+ const STILL_RUNNING = "9999-12-31T23:59:59Z" ;
1581+
15791582function realTimestamp ( value : string | null | undefined ) : string | null {
15801583 const at = trimmed ( value ) ;
15811584 return at === null || at === UNSET_TIMESTAMP ? null : at ;
@@ -1588,8 +1591,9 @@ function isNamelessCheck(raw: Schema.Schema.Type<typeof RawCheckSchema>): boolea
15881591
15891592/**
15901593 * The rollup as the deduper reads it: a check, the workflow that owns it, and when the run last
1591- * had something to say. A queued run reports a completion time it has not reached, so the start
1592- * stands in for it rather than sorting the newest run to the bottom.
1594+ * had something to say. A run that has not finished outranks any finished run of the same check:
1595+ * a workflow triggered by both `push` and `pull_request` runs the check twice on one commit, and
1596+ * the run that finished first must not hide the one still going.
15931597 */
15941598function toCheckEntries (
15951599 raw : ReadonlyArray < Schema . Schema . Type < typeof RawCheckSchema > > | null | undefined ,
@@ -1601,17 +1605,21 @@ function toCheckEntries(
16011605 return ( raw ?? [ ] ) . flatMap ( ( check ) => {
16021606 const name = trimmed ( check . name ) ?? trimmed ( check . context ) ;
16031607 if ( name === null ) return [ ] ;
1608+ const status = toCheckStatus ( check ) ;
16041609 return [
16051610 {
16061611 check : {
16071612 name,
1608- status : toCheckStatus ( check ) ,
1613+ status,
16091614 description : trimmed ( check . description ) ,
16101615 url : trimmed ( check . detailsUrl ) ?? trimmed ( check . targetUrl ) ,
16111616 ...( typeof check . isRequired === "boolean" ? { required : check . isRequired } : { } ) ,
16121617 } ,
16131618 workflowName : trimmed ( check . workflowName ) ,
1614- at : realTimestamp ( check . completedAt ) ?? realTimestamp ( check . startedAt ) ,
1619+ at :
1620+ status === "pending"
1621+ ? STILL_RUNNING
1622+ : ( realTimestamp ( check . completedAt ) ?? realTimestamp ( check . startedAt ) ) ,
16151623 } ,
16161624 ] ;
16171625 } ) ;
0 commit comments