Add testing coverage to #9572#1
Merged
RyaPorter merged 1 commit intoRyaPorter:ContextMenuAutoLacingfrom Mar 30, 2019
Merged
Conversation
Author
|
Hey @RyaPorter, thanks for the PR with a nice bug fix! This PR just adds some testing coverage over this functionality. Let me know if everything looks okay and we can get this merged into your PR and your PR merged into master. |
Owner
|
Hey @alfarok thanks! This looks good to me, I've merged into my PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
DYN-1710
This PR adds testing coverage to another open PR DynamoDS#9572 which has not yet been merged. I have already reviewed @RyaPorter 's work which looks good. Once this PR is reviewed it can be merged into DynamoDS#9572 followed by DynamoDS#9572 being merged into master.
Testing
This functionality is currently partially covered in
HelixWatch3DViewModelTests.cswhich areVisualizationTests. Unfortunately, these don't yet run in the automated pipeline so I modified the logic into a unit test that will be run in the pipeline. These tests confirm the appropriate command methods are called for each lacing operation. The final test verifies all 4 lacing options appear in the context menu.Declarations
Check these if you believe they are true
*.resxfilesReviewers
@RyaPorter
FYIs
@QilongTang @mjkkirschner