Skip to content

Add testing coverage to #9572#1

Merged
RyaPorter merged 1 commit intoRyaPorter:ContextMenuAutoLacingfrom
alfarok:ContextMenuAutoLacing
Mar 30, 2019
Merged

Add testing coverage to #9572#1
RyaPorter merged 1 commit intoRyaPorter:ContextMenuAutoLacingfrom
alfarok:ContextMenuAutoLacing

Conversation

@alfarok
Copy link

@alfarok alfarok commented Mar 29, 2019

Purpose

DYN-1710

This PR adds testing coverage to another open PR DynamoDS#9572 which has not yet been merged. I have already reviewed @RyaPorter 's work which looks good. Once this PR is reviewed it can be merged into DynamoDS#9572 followed by DynamoDS#9572 being merged into master.

Testing

This functionality is currently partially covered in HelixWatch3DViewModelTests.cs which are VisualizationTests. Unfortunately, these don't yet run in the automated pipeline so I modified the logic into a unit test that will be run in the pipeline. These tests confirm the appropriate command methods are called for each lacing operation. The final test verifies all 4 lacing options appear in the context menu.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@RyaPorter

FYIs

@QilongTang @mjkkirschner

@alfarok
Copy link
Author

alfarok commented Mar 29, 2019

Hey @RyaPorter, thanks for the PR with a nice bug fix! This PR just adds some testing coverage over this functionality. Let me know if everything looks okay and we can get this merged into your PR and your PR merged into master.

@alfarok alfarok changed the title Add testing coverage to #9483 Add testing coverage to #9572 Mar 29, 2019
@RyaPorter RyaPorter merged commit 353bf49 into RyaPorter:ContextMenuAutoLacing Mar 30, 2019
@RyaPorter
Copy link
Owner

Hey @alfarok thanks! This looks good to me, I've merged into my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants