You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 3924da9
Browse filesBrowse the repository at this point in the historyBrowse files
authored
fix(coverage-changed): refuse stale or foreign reports via the coverage stamp (callstack#4387)
* fix(coverage-changed): refuse stale or foreign reports via the coverage stamp
The changed-line gate scored whatever lcov file it found, so a stale
report or one written in another checkout read as a verdict — a foreign
report even passed 0/0. It now refuses before scoring when the stamp
beside the report is absent, names another commit or working tree, or
records a narrowed run, and when lcov records files outside this
checkout (the stamp cannot catch two checkouts of one commit). The
refusal fires before the coverage-waiver label is consulted.
Instrumentation now comes from the verified stamp's include/exclude,
shared with the CRAP gate, and the duplicated SOURCE_ROOT policy is
removed.
Closescallstack#4379
* fix(coverage-changed): address maintainer feedback on the stamp gate
Refusal now fires before the waiver when the report has no stamp (run-level test pins it). The excluded-path tally is restored for stamp-excluded files an include root covers, so new logic under an exclude entry still shows in the job summary. Both gates share one outside-root scan via a predicate in stamp.ts, with no schema change. The COVERAGE_CONFIG fixture is shared between the model and run suites, and the CONTRIBUTING wording now names both the no-verdict and no-report messages.
* fix(coverage-changed): widen test-material tally exclusion and share include matching
The excluded tally exists to surface hidden product logic, not test code,
but isTestFile missed test-kit helpers and fixtures files the stamp
excludes, so their lines were tallied as hidden product logic. Widen the
predicate to cover them, with a regression test that fails without the fix.
Extract one include-match helper in stamp.ts so isInstrumentedPath and
isIncludedPath cannot drift, and qualify the CONTRIBUTING sentence about
the tally to code-like, non-test additions.
* test(coverage-changed): mirror vitest test-material excludes in the shared fixture
Adds **/*.fixtures.ts and packages/test-kit/** to COVERAGE_CONFIG, per maintainer feedback on callstack#4387: the fixture should mirror the vitest config's test-material excludes instead of the tally test carrying its own extended copy. The test-kit/fixtures tally test now uses the shared fixture directly.
* fix(coverage-changed): satisfy the fallow audit on the gate entrypoint and scoring
Route the CLI entrypoint through the shared runEntrypoint owner instead of a
copied try/catch block, and score each changed file in one helper so
computeChangedCoverage stays under the complexity threshold. Behavior is
unchanged.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
---------
Co-authored-by: Huyvux12 <[email protected]>
Co-authored-by: Michał Pierzchała <[email protected]>
Co-authored-by: Claude Opus 5.5 <[email protected]>
0 commit comments