Skip to content

Conversation

@arihant2math
Copy link
Collaborator

@arihant2math arihant2math commented Feb 1, 2025

Supersedes #5482

Also:

  • Removes a difflib doctest (this can be added back during a difflib update)
  • Strips docstrings like cpython does
  • Marks some tests that got activated during 3.13 in test_enum as invalid.
  • Updates extra_tests to pass with cpython 3.13

@arihant2math arihant2math marked this pull request as ready for review February 1, 2025 00:49
@youknowone
Copy link
Member

I will immediately merge separately mergable changes like removing imghdr,sndhdr etc

@arihant2math
Copy link
Collaborator Author

arihant2math commented Feb 1, 2025

@youknowone everything works except some modules, should I disable the tests or update the modules?

@arihant2math arihant2math force-pushed the 313 branch 5 times, most recently from ebef7a1 to c8ad849 Compare February 3, 2025 19:59
@arihant2math arihant2math mentioned this pull request Feb 4, 2025
@arihant2math
Copy link
Collaborator Author

Marking as draft as the docstring whitespace stripping isn't passing all tests.

@arihant2math arihant2math marked this pull request as draft February 6, 2025 16:45
@arihant2math arihant2math changed the title Mark version 3.13.1 Mark version 3.13.0 Feb 6, 2025
@arihant2math arihant2math force-pushed the 313 branch 2 times, most recently from ce6585a to cf95bef Compare February 11, 2025 18:34
@arihant2math arihant2math marked this pull request as ready for review February 11, 2025 21:32
@arihant2math
Copy link
Collaborator Author

Ready for merge!

youknowone and others added 3 commits February 12, 2025 14:46
Signed-off-by: Ashwin Naren <[email protected]>
Signed-off-by: Ashwin Naren <[email protected]>
Signed-off-by: Ashwin Naren <[email protected]>
Signed-off-by: Ashwin Naren <[email protected]>
Signed-off-by: Ashwin Naren <[email protected]>
arihant2math and others added 13 commits February 12, 2025 16:13
Co-authored-by: Jeong, YunWon <[email protected]>
Signed-off-by: Ashwin Naren <[email protected]>
Signed-off-by: Ashwin Naren <[email protected]>
Signed-off-by: Ashwin Naren <[email protected]>
Co-authored-by: Jeong, YunWon <[email protected]>
Signed-off-by: Ashwin Naren <[email protected]>
Signed-off-by: Ashwin Naren <[email protected]>
Signed-off-by: Ashwin Naren <[email protected]>
Signed-off-by: Ashwin Naren <[email protected]>
Signed-off-by: Ashwin Naren <[email protected]>
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@youknowone youknowone merged commit a46ce8e into RustPython:main Feb 13, 2025
11 checks passed
@arihant2math
Copy link
Collaborator Author

🎉

@arihant2math arihant2math deleted the 313 branch February 25, 2025 15:41
@youknowone youknowone mentioned this pull request Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants