Create ContentItem with a macro (#5859)

ShaharNaveh · web-flow · commit b6ff541260a2 · 2025-06-30T00:22:52.000+09:00
* Create ContentItem with a macro

* Set struct docs via metadata
diff --git a/derive-impl/src/pyclass.rs b/derive-impl/src/pyclass.rs
@@ -653,72 +653,55 @@ pub(crate) fn impl_pyexception_impl(attr: PunctuatedNestedMeta, item: Item) -> R
     })
 }
 
-/// #[pymethod] and #[pyclassmethod]
-struct MethodItem {
-    inner: ContentItemInner<AttrName>,
-}
-
-/// #[pygetset]
-struct GetSetItem {
-    inner: ContentItemInner<AttrName>,
-}
-
-/// #[pyslot]
-struct SlotItem {
-    inner: ContentItemInner<AttrName>,
-}
-
-/// #[pyattr]
-struct AttributeItem {
-    inner: ContentItemInner<AttrName>,
-}
+macro_rules! define_content_item {
+    (
+        $(#[$meta:meta])*
+        $vis:vis struct $name:ident
+    ) => {
+        $(#[$meta])*
+        $vis struct $name {
+            inner: ContentItemInner<AttrName>,
+        }
 
-/// #[extend_class]
-struct ExtendClassItem {
-    inner: ContentItemInner<AttrName>,
-}
+        impl ContentItem for $name {
+            type AttrName = AttrName;
 
-/// #[pymember]
-struct MemberItem {
-    inner: ContentItemInner<AttrName>,
+            fn inner(&self) -> &ContentItemInner<AttrName> {
+                &self.inner
+            }
+        }
+    };
 }
 
-impl ContentItem for MethodItem {
-    type AttrName = AttrName;
-    fn inner(&self) -> &ContentItemInner<AttrName> {
-        &self.inner
-    }
-}
-impl ContentItem for GetSetItem {
-    type AttrName = AttrName;
-    fn inner(&self) -> &ContentItemInner<AttrName> {
-        &self.inner
-    }
-}
-impl ContentItem for SlotItem {
-    type AttrName = AttrName;
-    fn inner(&self) -> &ContentItemInner<AttrName> {
-        &self.inner
-    }
-}
-impl ContentItem for AttributeItem {
-    type AttrName = AttrName;
-    fn inner(&self) -> &ContentItemInner<AttrName> {
-        &self.inner
-    }
-}
-impl ContentItem for ExtendClassItem {
-    type AttrName = AttrName;
-    fn inner(&self) -> &ContentItemInner<AttrName> {
-        &self.inner
-    }
-}
-impl ContentItem for MemberItem {
-    type AttrName = AttrName;
-    fn inner(&self) -> &ContentItemInner<AttrName> {
-        &self.inner
-    }
-}
+define_content_item!(
+    /// #[pymethod] and #[pyclassmethod]
+    struct MethodItem
+);
+
+define_content_item!(
+    /// #[pygetset]
+    struct GetSetItem
+);
+
+define_content_item!(
+    /// #[pyslot]
+    struct SlotItem
+);
+
+define_content_item!(
+    /// #[pyattr]
+    struct AttributeItem
+);
+
+define_content_item!(
+    /// #[extend_class]
+    struct ExtendClassItem
+);
+
+define_content_item!(
+    /// #[pymember]
+    struct MemberItem
+);
 
 struct ImplItemArgs<'a, Item: ItemLike> {
     item: &'a Item,
