Avoid set changed size during iteration

moreal · moreal · commit 739bc8d09b89 · 2025-06-29T01:24:44.000+09:00
diff --git a/Lib/test/test_set.py b/Lib/test/test_set.py
@@ -582,8 +582,6 @@ def test_ixor(self):
             else:
                 self.assertNotIn(c, self.s)
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def test_inplace_on_self(self):
         t = self.s.copy()
         t |= t
diff --git a/vm/src/builtins/set.rs b/vm/src/builtins/set.rs
@@ -425,8 +425,9 @@ impl PySetInner {
         vm: &VirtualMachine,
     ) -> PyResult<()> {
         for iterable in others {
-            for item in iterable.iter(vm)? {
-                self.content.delete_if_exists(vm, &*item?)?;
+            let items = iterable.iter(vm)?.collect::<Result<Vec<_>, _>>()?;
+            for item in items {
+                self.content.delete_if_exists(vm, &*item)?;
             }
         }
         Ok(())

Original file line number	Diff line number	Diff line change
`@@ -425,8 +425,9 @@ impl PySetInner {`
`425`	`425`	`vm: &VirtualMachine,`
`426`	`426`	`) -> PyResult<()> {`
`427`	`427`	`for iterable in others {`
`428`		`- for item in iterable.iter(vm)? {`
`429`		`- self.content.delete_if_exists(vm, &*item?)?;`
	`428`	`+ let items = iterable.iter(vm)?.collect::<Result<Vec<_>, _>>()?;`
	`429`	`+ for item in items {`
	`430`	`+ self.content.delete_if_exists(vm, &*item)?;`
`430`	`431`	`}`
`431`	`432`	`}`
`432`	`433`	`Ok(())`