Move PrintExpr to IntristicFunction1

ShaharNaveh · ShaharNaveh · commit 70c3bf468be3 · 2025-12-02T17:58:13.000+02:00
diff --git a/crates/codegen/src/compile.rs b/crates/codegen/src/compile.rs
@@ -1056,7 +1056,14 @@ impl Compiler {
             for statement in body {
                 if let Stmt::Expr(StmtExpr { value, .. }) = &statement {
                     self.compile_expression(value)?;
-                    emit!(self, Instruction::PrintExpr);
+                    emit!(
+                        self,
+                        Instruction::CallIntrinsic1 {
+                            func: bytecode::IntrinsicFunction1::Print
+                        }
+                    );
+
+                    emit!(self, Instruction::Pop);
                 } else {
                     self.compile_statement(statement)?;
                 }
@@ -1065,7 +1072,14 @@ impl Compiler {
             if let Stmt::Expr(StmtExpr { value, .. }) = &last {
                 self.compile_expression(value)?;
                 emit!(self, Instruction::CopyItem { index: 1_u32 });
-                emit!(self, Instruction::PrintExpr);
+                emit!(
+                    self,
+                    Instruction::CallIntrinsic1 {
+                        func: bytecode::IntrinsicFunction1::Print
+                    }
+                );
+
+                emit!(self, Instruction::Pop);
             } else {
                 self.compile_statement(last)?;
                 self.emit_load_const(ConstantData::None);
diff --git a/crates/compiler-core/src/bytecode.rs b/crates/compiler-core/src/bytecode.rs
@@ -511,7 +511,7 @@ op_arg_enum!(
     #[repr(u8)]
     pub enum IntrinsicFunction1 {
         // Invalid = 0,
-        // Print = 1,
+        Print = 1,
         /// Import * operation
         ImportStar = 2,
         // StopIterationError = 3,
@@ -727,8 +727,6 @@ pub enum Instruction {
     PopJumpIfTrue {
         target: Arg<Label>,
     },
-
-    PrintExpr,
     Raise {
         kind: Arg<RaiseKind>,
     },
@@ -1702,7 +1700,6 @@ impl Instruction {
             }
             ListAppend { .. } | SetAdd { .. } => -1,
             MapAdd { .. } => -2,
-            PrintExpr => -1,
             LoadBuildClass => 1,
             UnpackSequence { size } => -1 + size.get(arg) as i32,
             UnpackEx { args } => {
@@ -1874,7 +1871,6 @@ impl Instruction {
             PopException => w!(PopException),
             PopJumpIfFalse { target } => w!(PopJumpIfFalse, target),
             PopJumpIfTrue { target } => w!(PopJumpIfTrue, target),
-            PrintExpr => w!(PrintExpr),
             Raise { kind } => w!(Raise, ?kind),
             Resume { arg } => w!(Resume, arg),
             ReturnConst { idx } => fmt_const("ReturnConst", arg, f, idx),
diff --git a/crates/vm/src/frame.rs b/crates/vm/src/frame.rs
@@ -1339,8 +1339,6 @@ impl ExecutingFrame<'_> {
             bytecode::Instruction::PopJumpIfTrue { target } => {
                 self.pop_jump_if(vm, target.get(arg), true)
             }
-            bytecode::Instruction::PrintExpr => self.print_expr(vm),
-
             bytecode::Instruction::Raise { kind } => self.execute_raise(vm, kind.get(arg)),
             bytecode::Instruction::Resume { arg: resume_arg } => {
                 // Resume execution after yield, await, or at function start
@@ -2196,18 +2194,6 @@ impl ExecutingFrame<'_> {
         Ok(None)
     }
 
-    fn print_expr(&mut self, vm: &VirtualMachine) -> FrameResult {
-        let expr = self.pop_value();
-
-        let displayhook = vm
-            .sys_module
-            .get_attr("displayhook", vm)
-            .map_err(|_| vm.new_runtime_error("lost sys.displayhook"))?;
-        displayhook.call((expr,), vm)?;
-
-        Ok(None)
-    }
-
     fn unpack_sequence(&mut self, size: u32, vm: &VirtualMachine) -> FrameResult {
         let value = self.pop_value();
         let elements: Vec<_> = value.try_to_value(vm).map_err(|e| {
@@ -2380,6 +2366,13 @@ impl ExecutingFrame<'_> {
         vm: &VirtualMachine,
     ) -> PyResult {
         match func {
+            bytecode::IntrinsicFunction1::Print => {
+                let displayhook = vm
+                    .sys_module
+                    .get_attr("displayhook", vm)
+                    .map_err(|_| vm.new_runtime_error("lost sys.displayhook"))?;
+                displayhook.call((arg,), vm)
+            }
             bytecode::IntrinsicFunction1::ImportStar => {
                 // arg is the module object
                 self.push_value(arg); // Push module back on stack for import_star
