Nit

coolreader18 · coolreader18 · commit 3b601331d293 · 2025-09-03T11:53:54.000-05:00
diff --git a/stdlib/src/mmap.rs b/stdlib/src/mmap.rs
@@ -338,8 +338,8 @@ mod mmap {
                 }
             };
 
-            let fd = unsafe { crt_fd::Borrowed::try_borrow_raw(fd) }.ok();
-            if let Some(fd) = fd {
+            let fd = unsafe { crt_fd::Borrowed::try_borrow_raw(fd) };
+            if let Ok(fd) = fd {
                 let metadata = fstat(fd)
                     .map_err(|err| io::Error::from_raw_os_error(err as i32).to_pyexception(vm))?;
                 let file_len = metadata.st_size;
@@ -365,7 +365,7 @@ mod mmap {
             let mmap_opt = mmap_opt.offset(offset.try_into().unwrap()).len(map_size);
 
             let (fd, mmap) = || -> std::io::Result<_> {
-                if let Some(fd) = fd {
+                if let Ok(fd) = fd {
                     let new_fd: crt_fd::Owned = unistd::dup(fd)?.into();
                     let mmap = match access {
                         AccessMode::Default | AccessMode::Write => {
diff --git a/stdlib/src/posixsubprocess.rs b/stdlib/src/posixsubprocess.rs
@@ -127,7 +127,7 @@ impl TryFromObject for Fd {
     fn try_from_object(vm: &VirtualMachine, obj: PyObjectRef) -> PyResult<Self> {
         match MaybeFd::try_from_object(vm, obj)? {
             MaybeFd::Valid(fd) => Ok(fd),
-            MaybeFd::Invalid => Err(vm.new_value_error("invalid fd".to_owned())),
+            MaybeFd::Invalid => Err(vm.new_value_error("invalid fd")),
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ impl TryFromObject for Fd {`
`127`	`127`	`fn try_from_object(vm: &VirtualMachine, obj: PyObjectRef) -> PyResult<Self> {`
`128`	`128`	`match MaybeFd::try_from_object(vm, obj)? {`
`129`	`129`	`MaybeFd::Valid(fd) => Ok(fd),`
`130`		`- MaybeFd::Invalid => Err(vm.new_value_error("invalid fd".to_owned())),`
	`130`	`+ MaybeFd::Invalid => Err(vm.new_value_error("invalid fd")),`
`131`	`131`	`}`
`132`	`132`	`}`
`133`	`133`	`}`