Correct symbols attr

ShaharNaveh · ShaharNaveh · commit 16f77376ee3b · 2025-07-30T18:01:24.000+02:00
diff --git a/Lib/test/test_symtable.py b/Lib/test/test_symtable.py
@@ -313,15 +313,11 @@ def test_referenced(self):
         self.assertTrue(self.spam.lookup("internal").is_referenced())
         self.assertFalse(self.spam.lookup("x").is_referenced())
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def test_parameters(self):
         for sym in ("a", "var", "kw"):
             self.assertTrue(self.spam.lookup(sym).is_parameter())
         self.assertFalse(self.spam.lookup("x").is_parameter())
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def test_symbol_lookup(self):
         self.assertEqual(len(self.top.get_identifiers()),
                          len(self.top.get_symbols()))
@@ -347,8 +343,6 @@ def test_namespaces(self):
         self.assertEqual(len(ns_test_2.get_namespaces()), 0)
         self.assertRaises(ValueError, ns_test_2.get_namespace)
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def test_assigned(self):
         self.assertTrue(self.spam.lookup("x").is_assigned())
         self.assertTrue(self.spam.lookup("bar").is_assigned())
@@ -388,8 +382,6 @@ def test_annotated(self):
     def test_imported(self):
         self.assertTrue(self.top.lookup("sys").is_imported())
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def test_name(self):
         self.assertEqual(self.top.get_name(), "top")
         self.assertEqual(self.spam.get_name(), "spam")
diff --git a/vm/src/stdlib/symtable.rs b/vm/src/stdlib/symtable.rs
@@ -3,7 +3,9 @@ pub(crate) use symtable::make_module;
 #[pymodule]
 mod symtable {
     use crate::{
-        PyObjectRef, PyPayload, PyRef, PyResult, VirtualMachine, builtins::PyStrRef, compiler,
+        PyObjectRef, PyPayload, PyRef, PyResult, VirtualMachine,
+        builtins::{PyDictRef, PyStrRef},
+        compiler,
     };
     use rustpython_codegen::symboltable::{Symbol, SymbolFlags, SymbolScope, SymbolTable};
     use std::fmt;
@@ -182,28 +184,13 @@ mod symtable {
         }
 
         #[pygetset]
-        fn symbols(&self, vm: &VirtualMachine) -> PyResult<Vec<PyObjectRef>> {
-            let symbols = self
-                .symtable
-                .symbols
-                .values()
-                .map(|s| {
-                    (PySymbol {
-                        symbol: s.clone(),
-                        namespaces: self
-                            .symtable
-                            .sub_tables
-                            .iter()
-                            .filter(|&table| table.name == s.name)
-                            .cloned()
-                            .collect(),
-                        is_top_scope: self.symtable.name == "top",
-                    })
-                    .into_ref(&vm.ctx)
-                    .into()
-                })
-                .collect();
-            Ok(symbols)
+        fn symbols(&self, vm: &VirtualMachine) -> PyResult<PyDictRef> {
+            let dict = vm.ctx.new_dict();
+            for (name, symbol) in &self.symtable.symbols {
+                dict.set_item(name, vm.new_pyobj(symbol.flags.bits()), vm)
+                    .unwrap();
+            }
+            Ok(dict)
         }
     }
 
