Python location transform and related refactoring#13
Merged
youknowone merged 7 commits intoRustPython:mainfrom May 10, 2023
Merged
Python location transform and related refactoring#13youknowone merged 7 commits intoRustPython:mainfrom
youknowone merged 7 commits intoRustPython:mainfrom
Conversation
youknowone
force-pushed
the
locator
branch
2 times, most recently
from
6e3c47f to
bda2eab
Compare
youknowone
force-pushed
the
locator
branch
4 times, most recently
from
32a70c2 to
a3f5d47
Compare
youknowone
changed the title
youknowone
force-pushed
the
locator
branch
4 times, most recently
from
1aef34d to
e092f76
Compare
- Split parser core and compiler core. Fix RustPython#14 - AST int type to `u32` - Updated asdl_rs.py and update_asdl.sh fix RustPython#6 - Use `ruff_python_ast::SourceLocation` for Python source location. Deleted our own Location. - Renamed ast::Located to ast::Attributed to distinguish terms for TextSize and SourceLocation - `ast::<Node>`s for TextSize located ast. `ast::located::<Node>` for Python source located ast. - And also strictly renaming `located` to refer only python location related interfaces. - `SourceLocator` to convert locations. - New `source-code` features of to disable python locations when unnecessary. - Also including fully merging astral-sh/RustPython#4 closes RustPython#9
youknowone
force-pushed
the
locator
branch
2 times, most recently
from
42b3e1f to
5cada82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
u32ruff_python_ast::SourceLocationfor Python source location. Deleted our own Location.ast::<Node>s for TextSize located ast.ast::located::<Node>for Python source located ast.locatedto refer only python location related interfaces.SourceLocatorto convert locations.source-codefeatures of to disable python locations when unnecessary.Unfortunately, Python symbols are containing line numbers regardless it has source or not.
RustPython may be able to defer the actual transform to symbol table and compile error.
But I decide not to do it right now to avoid even larger diff.