Conversation
Adds proptests for RSASSA-PKCS1-v1_5. Includes a commented-out test for RSASSA-PSS which is currently failing.
tarcieri
commented
May 4, 2023
Comment on lines
+32
to
+41
| // TODO(tarcieri): debug why these are failing | ||
| // #[test] | ||
| // fn pss_sign_roundtrip(private_key in private_key(), msg in any::<Vec<u8>>()) { | ||
| // let signing_key = pss::SigningKey::<Sha256>::new(private_key); | ||
| // let signature_bytes = signing_key.sign(&msg).to_bytes(); | ||
| // | ||
| // let verifying_key = signing_key.verifying_key(); | ||
| // let signature = pss::Signature::try_from(&*signature_bytes).unwrap(); | ||
| // prop_assert!(verifying_key.verify(&msg, &signature).is_ok()); | ||
| // } |
Member
Author
There was a problem hiding this comment.
These are at least blowing up inside of sign, so it's not producing a signature that fails to verify at least.
Somewhat concerning though. Hopefully related to the small key size?
takumi-earth
pushed a commit
to earthlings-dev/RSA
that referenced
this pull request
Jan 27, 2026
Adds proptests for RSASSA-PKCS1-v1_5. Includes a commented-out test for RSASSA-PSS which is currently failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds proptests for RSASSA-PKCS1-v1_5 and RSA-PSS.
NOTE: these are currently expected to fail, and to be resolved by #325