Fix compile error with VS 2013#29
Merged
dougbinks merged 1 commit intoRuntimeCompiledCPlusPlus:masterfrom Sep 8, 2013
ethan-tqa:master
Merged
Fix compile error with VS 2013#29dougbinks merged 1 commit intoRuntimeCompiledCPlusPlus:masterfrom ethan-tqa:master
dougbinks merged 1 commit intoRuntimeCompiledCPlusPlus:masterfrom
ethan-tqa:master
Conversation
Collaborator
|
Thanks, that's a good find. I'll be adding VS 2013 to my test suite when it's officially released, so should hopefully catch these issues in future. Note that algorithm can be included on all platforms for std::min and std::max, so I'll likely move to removing the #if once I get the chance to test this change on those platforms. For now I'll pull this. |
dougbinks
added a commit
that referenced
this pull request
Sep 8, 2013
Fix compile error with VS 2013
Contributor
Author
|
It is unlikely that VS 2013 will be released in the next few months, so I think you can actually grab VS 2013 Preview to test. |
Collaborator
|
I don't have a spare system or image ready to install VS Preview on, and from previous experience I know installing to my main system can mean a full re-install later, so I'll pass on the preview. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to this http://msdn.microsoft.com/en-us/library/vstudio/bb531344(v=vs.120).aspx, must be included to use std::min() and std::max()