You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit e74433e
Browse filesBrowse the repository at this point in the historyBrowse files
compose_box: Use pickMultipleMedia for attach-media on Android
Fixes part of zulip#855.
Fixeszulip#1510.
The attach-media button previously used 'FileType.media' from the
'file_picker' package on all platforms. On Android, that opens a
general file browser instead of a media gallery.
Switch to 'pickMultipleMedia' from 'image_picker', on Android only.
On iOS, file_picker already presents the native media picker, while
image_picker would re-encode picked images to JPEG, discarding the
original file. See:
zulip#2331 (review)
On Android, the new code can still open a general file browser on
certain Android versions. This is to be fixed in subsequent commits
by enabling the Android Photo Picker. See:
flutter/flutter#184826
// These tests fail on Windows because [XFile.name] splits on
1312
+
// [Platform.pathSeparator], corresponding to the actual host platform
1313
+
// the test is running on, instead of the path separator for the
1314
+
// target platform the test is simulating.
1315
+
// TODO(upstream): unskip after fix to https://github.com/flutter/flutter/issues/161073
// TODO test what happens when selecting/uploading fails
1267
1363
});
@@ -1313,10 +1409,6 @@ void main() {
1313
1409
1314
1410
// TODO test what happens when capturing/uploading fails
1315
1411
},
1316
-
// This test fails on Windows because [XFile.name] splits on
1317
-
// [Platform.pathSeparator], corresponding to the actual host platform
1318
-
// the test is running on, instead of the path separator for the
1319
-
// target platform the test is simulating.
1320
1412
// TODO(upstream): unskip after fix to https://github.com/flutter/flutter/issues/161073
0 commit comments