You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 240d165
Browse filesBrowse the repository at this point in the historyBrowse files
compose_box: Use pickMultipleMedia for the attach-media button
Fixes part of zulip#855.
Fixeszulip#1308.
Fixeszulip#1510.
The previous implementation used 'FileType.media' from the
'file_picker' package. We switched to using 'pickMultipleMedia' from
'image_picker' as it is a first-party package and is more actively
supported.
On Android, the current code can still open a general file browser
that lets user pick non-media files. This is to be fixed in
subsequent commits by enabling Android Photo Picker. See:
flutter/flutter#184826
// TODO test what happens when selecting/uploading fails
1267
-
});
1311
+
},
1312
+
// This test fails on Windows because [XFile.name] splits on
1313
+
// [Platform.pathSeparator], corresponding to the actual host platform
1314
+
// the test is running on, instead of the path separator for the
1315
+
// target platform the test is simulating.
1316
+
// TODO(upstream): unskip after fix to https://github.com/flutter/flutter/issues/161073
1317
+
skip:Platform.isWindows);
1268
1318
1269
1319
group('attach from camera', () {
1270
1320
testWidgets('success', (tester) async {
@@ -1313,10 +1363,6 @@ void main() {
1313
1363
1314
1364
// TODO test what happens when capturing/uploading fails
1315
1365
},
1316
-
// This test fails on Windows because [XFile.name] splits on
1317
-
// [Platform.pathSeparator], corresponding to the actual host platform
1318
-
// the test is running on, instead of the path separator for the
1319
-
// target platform the test is simulating.
1320
1366
// TODO(upstream): unskip after fix to https://github.com/flutter/flutter/issues/161073
// TODO(upstream): unskip after fix to https://github.com/flutter/flutter/issues/161073
0 commit comments