Skip to content

Conversation

@hannesrudolph
Copy link
Collaborator

@hannesrudolph hannesrudolph commented Dec 10, 2025

Summary

  • ensure nightly builds (0.0.x) select the highest available versioned settings without minimum-version gating
  • keep non-nightly behavior unchanged and retain plain-settings fallback when no versioned settings match
  • add a nightly coverage test mocking Package.version to 0.0.x to verify highest versionedSettings is applied

Changes

  • adjust versionedSettings resolver to treat nightly builds as always eligible and pick highest version key
  • add nightly test in roo provider fetcher specs to assert highest versionedSettings applies

Important

Nightly builds now select the highest available versioned settings without constraints, with tests added to verify this behavior.

  • Behavior:
    • Nightly builds (0.0.x) now select the highest available versionedSettings without minimum-version gating in versionedSettings.ts.
    • Non-nightly builds retain existing behavior, using plain settings if no versioned settings match.
  • Tests:
    • Added test in roo.spec.ts to verify highest versionedSettings is applied for nightly builds by mocking Package.name.
    • Added test in versionedSettings.spec.ts to ensure nightly builds pick the highest versioned settings.
  • Functions:
    • Modified findHighestMatchingVersion() in versionedSettings.ts to treat nightly builds as always eligible for highest version.

This description was created by Ellipsis for 5d18103. You can customize this summary. It will automatically update as commits are pushed.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Dec 10, 2025
@roomote
Copy link
Contributor

roomote bot commented Dec 10, 2025

Oroocle Clock   Follow along on Roo Cloud

Reviewing your PR now. Feedback coming soon!

Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Dec 10, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 10, 2025
@cte cte merged commit 483e70c into main Dec 10, 2025
13 checks passed
@cte cte deleted the fix/nightly-versioned-settings branch December 10, 2025 22:28
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Dec 10, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Dec 10, 2025
@cte cte mentioned this pull request Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants