feat: add error details modal with on-demand display #9985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add errorDetails prop to ErrorRow component - Show Info icon on hover in error header when errorDetails is provided - Display detailed error message in modal dialog on Info icon click - Add Copy to Clipboard button in error details modal - Update generic error case to show localized message with details on demand - Add i18n translations for error details UI
Contributor
Author
Review complete. No issues found. The latest commit (6e8b0b7) applies lighter visual treatment for errors by adjusting text colors and spacing. The changes are purely cosmetic refinements that improve the error display UX without introducing any functional issues. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
hannesrudolph
added
the
Issue/PR - Triage
dosubot
bot
added
size:L
Contributor
Author
Review complete. No issues found. The implementation correctly adds an error details modal with on-demand display. The changes follow existing patterns in the codebase:
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue where PR #9954 started showing the entirety of errors in ErrorRow. This PR restores the original intent from PR #9777 to keep error messages limited to defined messages, while adding the ability for users to view detailed error messages on demand.
In the process, I changed how we're tracking the retry timer to something a bit cleaner, which gives us more control and flexibility on the UI side, so the design looks a tad improved.
Hovering the item shows an
iicon which, when clicked, shows the raw error message in a modal.Keep in mind the quality of the content in the modal is 100% dependent on the quality of the error we send.
Changes
errorDetailsprop toErrorRowcomponent<Info />icon on hover in error header when errorDetails is provided<Copy />icon in error details modalChatRowto show localized "Error" message with full details available on demandapi_req_retry_delayedcase to store non-HTTP error messages as errorDetailsen/chat.jsonTesting
View task on Roo Code Cloud
Important
Adds error details modal in
ErrorRow.tsxfor on-demand viewing and refines retry timer logic inTask.ts.errorDetailsprop toErrorRowinErrorRow.tsxfor detailed error messages.<Info />icon on hover in error header whenerrorDetailsis provided.ChatRow.tsxto show localized "Error" message with full details on demand.errorDetailsinapi_req_retry_delayedcase.en/chat.json.Task.tsfor cleaner tracking and improved UI control.This description was created by
for 6e8b0b7. You can customize this summary. It will automatically update as commits are pushed.