Skip to content

Conversation

@hannesrudolph
Copy link
Collaborator

@hannesrudolph hannesrudolph commented Dec 9, 2025

Summary

BEFORE
image

AFTER
image

Fixes a bug where non-HTTP-status-code error messages (like "Request timed out.") were being replaced with the generic "API Request Failed" text in the retry error display.

Changes

  • Modified webview-ui/src/components/chat/ChatRow.tsx to display the actual error message when it doesn't start with an HTTP status code (400+)
  • Previously, the error handling code only parsed messages starting with HTTP status codes, causing other error messages to fall through to the generic i18n string

Testing

  • All existing tests pass
  • The fix ensures errors like "Request timed out." from the Roo Code Cloud proxy are now displayed to users instead of "API Request Failed"

Previously, when the API returned non-HTTP-status-code errors like
'Request timed out.', the UI would display the generic message
'API Request Failed' instead of the actual error text.

This fix ensures that error messages that don't start with HTTP status
codes (400+) are displayed directly to the user, improving error
visibility and debugging.
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Dec 9, 2025
@roomote
Copy link
Contributor

roomote bot commented Dec 9, 2025

Oroocle Clock   See task on Roo Cloud

Re-review complete for commit 2f664e9. No new issues were identified; existing checks remain satisfied.

  • Verify retry error messages render correctly for HTTP status code errors
  • Verify non-HTTP-status-code errors display the raw message text
  • Check ErrorRow usage and docs link behavior for retry-delayed errors
  • Confirm no regressions in surrounding API request flow
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Dec 9, 2025
@hannesrudolph hannesrudolph moved this from Triage to PR [Needs Review] in Roo Code Roadmap Dec 9, 2025
@hannesrudolph hannesrudolph added PR - Needs Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Dec 9, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Dec 9, 2025
@hannesrudolph hannesrudolph force-pushed the fix/display-actual-api-error-message branch from e3d75a0 to 2f664e9 Compare December 9, 2025 20:42
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Dec 9, 2025
@cte cte requested a review from brunobergher December 9, 2025 20:48
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 9, 2025
@brunobergher
Copy link
Collaborator

🙌

@cte cte merged commit f89a6be into main Dec 9, 2025
38 checks passed
@cte cte deleted the fix/display-actual-api-error-message branch December 9, 2025 20:53
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Dec 9, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer PR - Needs Review size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants