-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix: display actual API error message instead of generic text on retry #9954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when the API returned non-HTTP-status-code errors like 'Request timed out.', the UI would display the generic message 'API Request Failed' instead of the actual error text. This fix ensures that error messages that don't start with HTTP status codes (400+) are displayed directly to the user, improving error visibility and debugging.
Contributor
Re-review complete for commit 2f664e9. No new issues were identified; existing checks remain satisfied.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
e3d75a0 to
2f664e9
Compare
cte
approved these changes
Dec 9, 2025
Collaborator
|
🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
lgtm
This PR has been approved by a maintainer
PR - Needs Review
size:XS
This PR changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
BEFORE

AFTER

Fixes a bug where non-HTTP-status-code error messages (like "Request timed out.") were being replaced with the generic "API Request Failed" text in the retry error display.
Changes
webview-ui/src/components/chat/ChatRow.tsxto display the actual error message when it doesn't start with an HTTP status code (400+)Testing