Skip to content

feat: Make Architect save to /plans and gitignore it #9944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrubens merged 3 commits into from
Dec 9, 2025
Merged

feat: Make Architect save to /plans and gitignore it #9944

mrubens merged 3 commits into from
Dec 9, 2025

Conversation

@brunobergher
Copy link
Collaborator

@brunobergher brunobergher commented Dec 9, 2025 •
edited by ellipsis-dev bot
Loading

Motivation

When working in architect mode, plan files created during the planning process currently clutter the git repository. This PR provides a dedicated location for architect mode to save plan files and excludes them from version control.

Key Changes

  • Added /plans directory to .gitignore - Prevents plan files from being tracked in version control
  • Updated architect mode instructions - Added guidance to save plan files in the /plans directory unless instructed otherwise
  • Fixed typo - Corrected 'diretory' → 'directory' in architect mode instructions
  • Updated test snapshots - Refreshed snapshots to reflect the updated architect mode custom instructions

Benefits

  • Cleaner git history without transient plan files
  • Consistent location for architect mode outputs
  • Better user experience when navigating the workspace

Important

Plan files in architect mode are now saved to /plans directory, which is gitignored, with updated instructions and test snapshots.

  • Behavior:
    • Plan files in architect mode are now saved to /plans directory.
    • /plans directory added to .gitignore to prevent version control tracking.
  • Instructions:
    • Updated architect mode instructions in mode.ts to specify saving plan files in /plans unless otherwise instructed.
    • Fixed typo in architect mode instructions ('diretory' to 'directory').
  • Tests:
    • Updated test snapshots in add-custom-instructions and system-prompt to reflect new instructions for saving plan files.

This description was created by Ellipsis for f91f820. You can customize this summary. It will automatically update as commits are pushed.

@brunobergher
infra: add /plans directory for architect mode outputs
fa5113c 
- Added /plans directory to .gitignore to exclude plan files from version control
- Updated architect mode custom instructions to guide saving plan files in /plans directory
- Fixed typo: 'diretory' -> 'directory'
- Updated test snapshots to reflect new architect mode instructions
@roomote
Copy link
Contributor

roomote bot commented Dec 9, 2025 •
edited
Loading

Rooviewer Clock   See task on Roo Cloud

Snapshot files have been correctly updated. All tests pass. One pre-existing issue remains unfixed.

  • Fix leading space in customInstructions for architect mode (packages/types/src/mode.ts)
  • Add trailing newline to .gitignore
  • Regenerate snapshot files to match corrected architect mode instructions
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

roomote[bot]
roomote bot reviewed Dec 9, 2025
View reviewed changes
roomote[bot]
roomote bot reviewed Dec 9, 2025
View reviewed changes
.gitignore
qdrant_storage/

# Architect plans
plans/
Copy link
Contributor

@roomote roomote bot Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: the file is missing a trailing newline. POSIX standards recommend text files end with a newline character.

Suggested change
plans/
plans/

Fix it with Roo Code or mention @roomote and request a fix.

@brunobergher brunobergher changed the title infra: add /plans directory for architect mode outputs feat: Make Architect save to /plans and gitignore it Dec 9, 2025
@brunobergher @roomote
Update packages/types/src/mode.ts
59e775d 
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
@brunobergher brunobergher marked this pull request as ready for review December 9, 2025 12:57
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Enhancement New feature or request labels Dec 9, 2025
@roomote
Copy link
Contributor

roomote bot commented Dec 9, 2025 •
edited
Loading

Rooviewer Clock   See task on Roo Cloud

Found 2 issues that need to be addressed:

  • Regenerate snapshot files after mode.ts formatting fix (12 failing tests in system-prompt.spec.ts and add-custom-instructions.spec.ts)
  • Add trailing newline to .gitignore

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Dec 9, 2025
roomote[bot]
roomote bot reviewed Dec 9, 2025
View reviewed changes
roomote[bot]
roomote bot reviewed Dec 9, 2025
View reviewed changes
.gitignore
qdrant_storage/

# Architect plans
plans/
Copy link
Contributor

@roomote roomote bot Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file is missing a trailing newline. POSIX standards recommend text files end with a newline character to ensure proper handling by text processing tools.

Suggested change
plans/
plans/

Fix it with Roo Code or mention @roomote and request a fix.

@mrubens
Copy link
Collaborator

mrubens commented Dec 9, 2025

@roomote please fix the snapshots

@roomote
Copy link
Contributor

roomote bot commented Dec 9, 2025 •
edited
Loading

Fixaroo Clock   See task on Roo Cloud

Updated 12 snapshot files to match the corrected architect mode instructions. All local checks passed.

View commit | Revert commit

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 9, 2025
@mrubens mrubens merged commit 8a98f14 into main Dec 9, 2025
12 checks passed
@mrubens mrubens deleted the bb/planner-plans branch December 9, 2025 14:51
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Dec 9, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roomote roomote[bot] roomote[bot] approved these changes

@mrubens mrubens mrubens approved these changes

@cte cte Awaiting requested review from cte cte is a code owner

@jr jr Awaiting requested review from jr jr is a code owner

Assignees

No one assigned

Labels

Enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Roo Code Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@brunobergher @mrubens @hannesrudolph @roomote