Skip to content

Make eval runs deleteable #9909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrubens merged 1 commit into from
Dec 8, 2025
Merged

Make eval runs deleteable #9909

mrubens merged 1 commit into from
Dec 8, 2025

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Dec 8, 2025 •
edited
Loading

I'm not able to delete eval runs to update them with more recent ones because of this:

Unable to delete row as it is currently referenced by a foreign key constraint from the table tasks DETAIL: Key (id)=(50) is still referenced from table tasks.
Set an on delete behavior on the foreign key relation tasks_run_id_runs_id_fk in the tasks DETAIL: Key (id)=(50) is still referenced from table tasks. table to automatically respond when row(s) are being deleted in the runs table.

@mrubens mrubens requested review from cte and jr as code owners December 8, 2025 04:13
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Dec 8, 2025
@roomote
Copy link
Contributor

roomote bot commented Dec 8, 2025 •
edited
Loading

Rooviewer Clock   See task on Roo Cloud

Review complete. The changes correctly implement cascading deletes for eval runs by updating foreign key constraints in the database schema. The migration properly drops and recreates the necessary constraints, and the schema changes are consistent with the migration.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Dec 8, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 8, 2025
@mrubens mrubens merged commit 1f7e1ee into main Dec 8, 2025
24 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Dec 8, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Dec 8, 2025
@mrubens mrubens deleted the make_evals_deleteable branch December 8, 2025 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cte cte cte approved these changes

@roomote roomote[bot] roomote[bot] approved these changes

@jr jr Awaiting requested review from jr jr is a code owner

Assignees

No one assigned

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Roo Code Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mrubens @cte @hannesrudolph