Skip to content

Conversation

@brunobergher
Copy link
Collaborator

@brunobergher brunobergher commented Dec 1, 2025

This doesn't change anything structurally or in terms of functionality, except that I removed the fine-grained Provider settings from the flow, as they're overwhelming to someone just getting started. they're all still there in Settings. Beyond that, it's just copy and UX tweaks.

Screenshot 2025-12-01 at 11 29 52
Screenshot 2025-12-01 at 11 30 11
Screenshot 2025-12-01 at 11 29 21
Screenshot 2025-12-01 at 11 29 27
Screenshot 2025-12-01 at 11 29 40

Important

Improves onboarding flow by simplifying provider settings and enhancing UI/UX in ApiOptions.tsx, ModelPicker.tsx, and WelcomeViewProvider.tsx.

  • Behavior:
    • Removed detailed provider settings from onboarding flow; available in Settings.
    • Simplified settings for new users in ApiOptions.tsx and ModelPicker.tsx.
  • UI/UX:
    • Updated WelcomeViewProvider.tsx to improve user guidance and error handling.
    • Adjusted UI elements in ChatView.tsx and ApiOptions.tsx for better clarity.
  • Code Changes:
    • Replaced fromWelcomeView with simplifySettings in multiple components.
    • Added simplifySettings prop to various provider components for conditional rendering.
    • Updated tests in Gemini.spec.tsx and Vertex.spec.tsx to reflect new prop changes.
  • Localization:
    • Updated translation files to include new strings for simplified settings and error messages.

This description was created by Ellipsis for 6d8a666. You can customize this summary. It will automatically update as commits are pushed.

@roomote
Copy link
Contributor

roomote bot commented Dec 1, 2025

Rooviewer Clock   See task on Roo Cloud

All issues resolved. This commit adds i18n translations for two new keys across 15 locale files with no code changes.

  • CSS typo in ChatView.tsx: p=0 should be p-0 for proper padding
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Dec 1, 2025
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
@brunobergher brunobergher marked this pull request as ready for review December 1, 2025 12:49
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. UI/UX UI/UX related or focused labels Dec 1, 2025
@roomote
Copy link
Contributor

roomote bot commented Dec 1, 2025

Rooviewer Clock   See task on Roo Cloud

All issues resolved. This PR successfully simplifies the onboarding flow by hiding advanced provider settings during welcome, improving visual presentation, and adding appropriate i18n translations.

  • CSS typo in ChatView.tsx: p=0 should be p-0 for proper padding (fixed in commit 82791bc)

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

Comment on lines +490 to +493
<VSCodeLink href={docs.url} target="_blank" className="flex gap-2">
{docs.name}
<BookOpenText className="size-4 inline ml-2" />
</VSCodeLink>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so much better

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 1, 2025
@mrubens mrubens merged commit f26d5a4 into main Dec 1, 2025
30 of 33 checks passed
@mrubens mrubens deleted the bb/new-user-flow-tweaks branch December 1, 2025 14:39
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Dec 1, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Dec 1, 2025
mini2s added a commit to zgsm-ai/costrict that referenced this pull request Dec 2, 2025
* feat: add tool protocol selector to advanced settings (RooCodeInc#9324)

Co-authored-by: Roo Code <[email protected]>
Co-authored-by: Matt Rubens <[email protected]>

* Remove experimental setting for native tool calls (RooCodeInc#9333)

* Fix the type of the list files recursive parameter (RooCodeInc#9337)

* fix: use VSCode theme color for outline button borders (RooCodeInc#9336)

Co-authored-by: Roo Code <[email protected]>
Co-authored-by: Bruno Bergher <[email protected]>

* feat: update cloud agent CTA to point to setup page (RooCodeInc#9338)

Co-authored-by: Roo Code <[email protected]>

* Improve Google Gemini defaults, temperature, and cost reporting (RooCodeInc#9327)

* fix: sync parser state with profile/model changes (RooCodeInc#9355)

* feat: enable native tool calling for openai-native provider (RooCodeInc#9348)

Co-authored-by: daniel-lxs <[email protected]>

* Add Gemini 3 Pro Preview model (RooCodeInc#9357)

* fix: pass tool protocol parameter to lineCountTruncationError (RooCodeInc#9358)

* Remove the Roo model defaults (RooCodeInc#9340)

* chore: add changeset and announcement for v3.33.0 (RooCodeInc#9360)

* Changeset version bump (RooCodeInc#9362)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Matt Rubens <[email protected]>

* fix: resolve native tool protocol race condition causing 400 errors (RooCodeInc#9363)

* Retry eval tasks if API instability detected (RooCodeInc#9365)

* fix: exclude XML tool examples from MODES section when native protocol enabled (RooCodeInc#9367)

* Add native tool calling support to OpenAI-compatible (RooCodeInc#9369)

* Add native tool calling support to OpenAI-compatible

* Fix OpenAI strict mode schema validation by adding converter methods to BaseProvider

- Add convertToolsForOpenAI() and convertToolSchemaForOpenAI() methods to BaseProvider
- These methods ensure all properties are in required array and convert nullable types
- Remove line_ranges from required array in read_file tool (converter handles it)
- Update OpenAiHandler and BaseOpenAiCompatibleProvider to use helper methods
- Eliminates code duplication across multiple tool usage sites
- Fixes: OpenAI completion error: 400 Invalid schema for function 'read_file'

---------

Co-authored-by: daniel-lxs <[email protected]>

* fix: ensure no XML parsing when protocol is native (RooCodeInc#9371)

* fix: ensure no XML parsing when protocol is native

* refactor: remove redundant non-null assertions

* fix: gemini maxOutputTokens and reasoning config (RooCodeInc#9375)

* fix: gemini maxOutputTokens and reasoning config

* test: tighten gemini reasoning typings

* fix: Update tools to return structured JSON for native protocol (RooCodeInc#9373)

* feat: add toolProtocol property to PostHog tool usage telemetry (RooCodeInc#9374)

Co-authored-by: Roo Code <[email protected]>
Co-authored-by: Matt Rubens <[email protected]>
Co-authored-by: daniel-lxs <[email protected]>

* fix: Include nativeArgs in tool repetition detection (RooCodeInc#9377)

* fix: Include nativeArgs in tool repetition detection

Fixes false positive 'stuck in a loop' error for native protocol tools
like read_file that store parameters in nativeArgs instead of params.

Previously, the ToolRepetitionDetector only compared the params object,
which was empty for native protocol tools. This caused all read_file
calls to appear identical, triggering false loop detection even when
reading different files.

Changes:
- Updated serializeToolUse() to include nativeArgs in comparison
- Added comprehensive tests for native protocol scenarios
- Maintains backward compatibility with XML protocol tools

Closes: Issue reported in Discord about read_file loop detection

* Try to use safe-stable-stringify in the tool repetition detector

---------

Co-authored-by: Matt Rubens <[email protected]>

* Fix Gemini thought signature validation and token counting errors (RooCodeInc#9380)

Co-authored-by: Matt Rubens <[email protected]>

* Release v3.33.1 (RooCodeInc#9383)

* Changeset version bump (RooCodeInc#9384)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Matt Rubens <[email protected]>

* fix: preserve user images in native tool call results (RooCodeInc#9401)

* feat: migrate PostHog client to ph.roocode.com (RooCodeInc#9402)

Co-authored-by: Roo Code <[email protected]>
Co-authored-by: Matt Rubens <[email protected]>

* feat: enable native tool calling for gemini provider (RooCodeInc#9343)

Co-authored-by: daniel-lxs <[email protected]>

* Add a RCC credit balance display (RooCodeInc#9386)

* Add a RCC credit balance display

* Replace the provider docs with the balance when logged in

* PR feedback

---------

Co-authored-by: Matt Rubens <[email protected]>

* perf: reduce excessive getModel() calls & implement disk cache fallback (RooCodeInc#9410)

* Show zero price for free models (RooCodeInc#9419)

* Release v3.33.2 (RooCodeInc#9420)

* Changeset version bump (RooCodeInc#9421)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Matt Rubens <[email protected]>

* Improve read_file tool description with examples (RooCodeInc#9422)

* Improve read_file tool description with examples

- Add explicit JSON structure documentation
- Include three concrete examples (single file, with line ranges, multiple files)
- Clarify that 'path' is required and 'line_ranges' is optional
- Better explain line range format (1-based inclusive)

This addresses agent confusion by providing clear examples similar to the XML tool definition.

* Make read_file tool dynamic based on partialReadsEnabled setting

- Convert read_file from static export to createReadFileTool() factory function
- Add getNativeTools() function that accepts partialReadsEnabled parameter
- Create buildNativeToolsArray() helper to encapsulate tool building logic
- Update Task.ts to build native tools dynamically using maxReadFileLine setting
- When partialReadsEnabled is false, line_ranges parameter is excluded from schema
- Examples and descriptions adjust based on whether line ranges are supported

This matches the behavior of the XML tool definition which dynamically adjusts
its documentation based on settings, reducing confusion for agents.

* Fix Marketplace crash by removing wildcard activation event (RooCodeInc#9423)

* Revert "Fix Marketplace crash by removing wildcard activation event" (RooCodeInc#9432)

* Fix OpenAI Native parallel tool calls for native protocol (RooCodeInc#9433)

Fixes an issue where using the OpenAI Native provider together with Native Tool Calling could cause OpenAI’s Responses API to fail with errors like:

* feat: add Google Gemini 3 Pro Image Preview to image generation models (RooCodeInc#9440)

Co-authored-by: Roo Code <[email protected]>
Co-authored-by: Matt Rubens <[email protected]>

* fix: prevent duplicate environment_details when resuming cancelled tasks (RooCodeInc#9442)

- Filter out complete environment_details blocks before appending fresh ones
- Check for both opening and closing tags to ensure we're matching complete blocks
- Prevents stale environment data from being kept during task resume
- Add tests to verify deduplication logic and edge cases

* Update glob to ^11.1.0 (RooCodeInc#9449)

* chore: update tar-fs to 3.1.1 via pnpm override (RooCodeInc#9450)

Co-authored-by: Roo Code <[email protected]>

* Store reasoning in conversation history for all providers (RooCodeInc#9451)

* Fix preserveReasoning flag to control API reasoning inclusion (RooCodeInc#9453)

* feat: store reasoning in conversation history for all providers

* refactor: address review feedback

- Move comments inside else block
- Combine reasoning checks into single if block
- Make comments more concise

* refactor: make comments more concise

* Fix preserveReasoning flag to control API reasoning inclusion

Changes:
1. Removed hardcoded <think> tag logic in streaming
   - Previously hardcoded reasoning into assistant message text
   - Now passes reasoning to addToApiConversationHistory as parameter

2. Updated buildCleanConversationHistory to respect preserveReasoning flag
   - When preserveReasoning: true → reasoning block included in API requests
   - When preserveReasoning: false/undefined → reasoning stripped from API
   - Reasoning stored in history for all cases

3. Added temporary debug logs to base-openai-compatible-provider.ts
   - Shows preserveReasoning flag value
   - Logs reasoning blocks in incoming messages
   - Logs <think> tags in converted messages sent to API

* Fix: Use api.getModel() directly instead of cachedStreamingModel

Addresses review comment: cachedStreamingModel is set during streaming but
buildCleanConversationHistory is called before streaming starts. Using the
cached value could cause stale model info when switching models between requests.

Now directly uses this.api.getModel().info.preserveReasoning to ensure we
always check the current model's flag, not a potentially stale cached value.

* Clean up comments in Task.ts

Removed outdated comment regarding model's preserveReasoning flag.

* fix: remove unnecessary reasoningBlock variable in task reasoning logic

* fix: send tool_result blocks for skipped tools in native protocol (RooCodeInc#9457)

* fix: improve markdown formatting and add reasoning support (RooCodeInc#9458)

* feat: implement Minimax as Anthropic-compatible provider (RooCodeInc#9455)

* fix: improve search and replace symbol parsing (RooCodeInc#9456)

* chore: add changeset for v3.33.3 (RooCodeInc#9459)

* Changeset version bump (RooCodeInc#9460)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Matt Rubens <[email protected]>

* feat(terminal): add inline shell integration with user input support

* Release: v1.87.0 (RooCodeInc#9477)

* refactor(terminal): remove inline shell integration callback and improve terminal process handling

* fix: add fallback to yield tool calls regardless of finish_reason (RooCodeInc#9476)

* Improvements to base openai compatible (RooCodeInc#9462)

Co-authored-by: Roo Code <[email protected]>

* Browser Use 2.0 (RooCodeInc#8941)

Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
Co-authored-by: daniel-lxs <[email protected]>

* fix: resolve apply_diff performance regression from PR RooCodeInc#9456 (RooCodeInc#9474)

* fix: implement model cache refresh to prevent stale disk cache (RooCodeInc#9478)

* fix: Make cancel button immediately responsive during streaming (RooCodeInc#9448)

* Test a provider-oriented welcome screen (RooCodeInc#9484)

Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>

* (feat): Add Baseten Provider (RooCodeInc#9461)

Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
Co-authored-by: AlexKer <[email protected]>
Co-authored-by: Matt Rubens <[email protected]>

* fix: copy model-level capabilities to OpenRouter endpoint models (RooCodeInc#9483)

* Pin the Roo provider to the top of the list (RooCodeInc#9485)

* Wait to experiment until state is hydrated (RooCodeInc#9488)

* Change baseten default model to glm for now (RooCodeInc#9489)

* Revert "Wait to experiment until state is hydrated" (RooCodeInc#9491)

* Try to fix build (RooCodeInc#9490)

* Update webview-ui Vite config (RooCodeInc#9493)

* Enhance native tool descriptions with examples and clarifications (RooCodeInc#9486)

* Revert "Revert "Wait to experiment until state is hydrated"" (RooCodeInc#9494)

* chore: add changeset and announcement for v3.34.0 (RooCodeInc#9495)

* Changeset version bump (