Skip to content

Conversation

@hannesrudolph
Copy link
Collaborator

@hannesrudolph hannesrudolph commented Nov 27, 2025

Summary

Claude Code manages its own tools and temperature via the CLI, so these capabilities should be disabled in the model definitions.

Changes

  • Add supportsNativeTools: false and supportsTemperature: false to all Claude Code model definitions in packages/types/src/providers/claude-code.ts
  • Refactor ClaudeCodeHandler to not extend BaseProvider (implements ApiHandler directly)
  • Add proper TypeScript return type to getModel() method
  • Implement required countTokens() method directly in the class

Why

Since Claude Code operates as a CLI wrapper that manages its own tool execution and temperature settings, exposing these options in the model capabilities was misleading and could cause configuration conflicts.


Important

Disable native tools and temperature support in Claude Code models and refactor ClaudeCodeHandler to implement ApiHandler directly.

  • Model Definitions:
    • Add supportsNativeTools: false and supportsTemperature: false to all Claude Code model definitions in claude-code.ts.
  • Class Refactoring:
    • Refactor ClaudeCodeHandler to implement ApiHandler directly, removing extension of BaseProvider.
    • Add TypeScript return type to getModel() method.
    • Implement countTokens() method directly in ClaudeCodeHandler.

This description was created by Ellipsis for 8445799. You can customize this summary. It will automatically update as commits are pushed.

Claude Code manages its own tools and temperature via the CLI,
so these capabilities should be disabled in the model definitions.

Also refactors ClaudeCodeHandler to not extend BaseProvider and
adds proper TypeScript return types.
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Nov 27, 2025
@roomote
Copy link
Contributor

roomote bot commented Nov 27, 2025

Oroocle Clock   Follow along on Roo Cloud

Reviewing your PR now. Will share feedback in a moment!

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 27, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 27, 2025
@mrubens mrubens merged commit f5ce56c into main Nov 27, 2025
21 checks passed
@mrubens mrubens deleted the fix/claude-code-model-capabilities branch November 27, 2025 04:56
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Nov 27, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Nov 27, 2025
@TheTravel3r TheTravel3r mentioned this pull request Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants