-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(web-evals): add task log viewing, export failed logs, and new run options #9637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Review updated for the latest commit. One issue in the task log viewer JSX/highlighting remains open.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
…n options - Add task log viewing dialog with syntax highlighting and copy to clipboard - Add export failed logs functionality (downloads zip file) - Add 'Use Multiple Native Tool Calls' option for all providers - Add reasoning effort dropdown for Roo Code Cloud provider - Improve job token field with tooltip and validation - Mount log files in docker-compose for web access - Add archiver dependency for zip exports
…d logs export - Add /api/runs/[id]/logs/[taskId] route to retrieve individual task logs - Add /api/runs/[id]/logs/failed route to export failed task logs as zip - Add archiver dependency for zip file generation - Remove redundant ESC key handler (Radix Dialog handles this) - Fixes missing functionality from original PR
- Fix XSS vulnerability in formatLogContent by escaping HTML before injecting spans - Use async fs.readFile instead of sync fs.readFileSync to avoid blocking event loop - Add path sanitization to prevent path traversal attacks in log file APIs - Add defense-in-depth path validation to ensure resolved paths stay within LOG_BASE_PATH - Add archiver error handler to properly handle archive generation errors - Fix event listener ordering: register 'end' handler before calling finalize() - Add empty zip detection: return 404 error if no log files found on disk - Fix toolProtocol not being applied for 'other' provider in new-run.tsx
- Add iterations slider (1-10) to new run form - Add iteration column to tasks table schema - Add ESC key handler to close task log dialog - Update run display to show iteration number for repeated tasks - Add database migration for iteration column
70f6c8c to
ed51c0e
Compare
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
…log highlighting - Fixed malformed JSX in formatLogContent function (duplicate nested div elements) - Replaced HTML string injection with proper React elements for XSS-safe syntax highlighting - Addresses review feedback about dangerouslySetInnerHTML security concern
mrubens
approved these changes
Nov 28, 2025
Summary
This PR enhances the web-evals application with several new features:
Task Log Viewing
Export Failed Logs
New Run Options
Iterations Support
Docker Configuration
Dependencies
archiverpackage for zip file generation@types/archiverfor TypeScript supportImportant
Enhance web-evals with task log viewing, export failed logs, new run options, and database schema updates for iterations.
run.tsx.route.tsto export failed task logs as a zip file.run.tsxto trigger log export.new-run.tsx.new-run.tsx.createRuninruns.tsto handle multiple iterations per exercise.0004_sloppy_black_knight.sqlto additerationcolumn totaskstable.docker-compose.ymlanddocker-compose.override.ymlto mount log files for web access.archiverand@types/archiverfor zip file generation inpackage.json.This description was created by
for 13016ee. You can customize this summary. It will automatically update as commits are pushed.