fix: OpenRouter GPT-5 strict schema validation for read_file tool #9633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
Contributor
Re-review found 1 new issue:
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
hannesrudolph
added
the
Issue/PR - Triage
Fix read_file native tool to include line_ranges in required array when partialReadsEnabled. OpenAI strict mode requires all properties in required array (nullable ones use type: [string, null]).
daniel-lxs
force-pushed
the
fix/openrouter-gpt5-strict-schema
branch
from
d69e5c4 to
e5e3a6c
Compare
dosubot
bot
added
size:XS
mrubens
approved these changes
Nov 26, 2025
hannesrudolph
added
PR - Needs Review
and removed
Issue/PR - Triage
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix read_file native tool schema to include
line_rangesin the required array whenpartialReadsEnabledis true.OpenAI's strict mode requires all properties to be in the
requiredarray - optional properties should usetype: ["array", "null"].